Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1470)

Unified Diff: chrome/browser/extensions/api/app_window/app_window_apitest.cc

Issue 11442038: More debugging output for PlatformAppBrowserTest.WindowsApiBounds GTK failures (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: added comment with link to bug Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/app_window/app_window_apitest.cc
diff --git a/chrome/browser/extensions/api/app_window/app_window_apitest.cc b/chrome/browser/extensions/api/app_window/app_window_apitest.cc
index e1b97a2a01999e8d4d84f215868d2526b7f43602..4a91534fb3073b3adb662add11b829a3ff01e84a 100644
--- a/chrome/browser/extensions/api/app_window/app_window_apitest.cc
+++ b/chrome/browser/extensions/api/app_window/app_window_apitest.cc
@@ -14,6 +14,10 @@
#include "chrome/test/base/testing_profile.h"
#include "ui/gfx/rect.h"
+#ifdef TOOLKIT_GTK
+#include "content/public/test/test_utils.h"
+#endif
+
namespace {
class TestShellWindowRegistryObserver
@@ -72,6 +76,23 @@ IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, WindowsApiBounds) {
#endif // !TOOLKIT_GTK
ready_listener.Reply(base::IntToString(slop));
+
+#ifdef TOOLKIT_GTK
+ // TODO(asargent)- this is here to help track down the root cause of
+ // crbug.com/164735.
+ {
+ gfx::Rect last_bounds;
+ while (!success_listener.was_satisfied()) {
+ gfx::Rect current_bounds = window->GetBaseWindow()->GetBounds();
+ if (current_bounds != last_bounds) {
+ LOG(INFO) << "new bounds: " << current_bounds.ToString();
+ }
+ last_bounds = current_bounds;
+ content::RunAllPendingInMessageLoop();
+ }
+ }
+#endif
+
ASSERT_TRUE(success_listener.WaitUntilSatisfied());
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698