Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11442036: Magnifier: Change the login-screen default scale from 1.0x to 2.0x (Closed)

Created:
8 years ago by yoshiki
Modified:
8 years ago
CC:
chromium-reviews, dtseng+watch_chromium.org, sadrul, nkostylev+watch_chromium.org, hashimoto+watch_chromium.org, ben+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, ctguil+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, zork+watch_chromium.org
Visibility:
Public.

Description

Magnifier: Change the login-screen default scale from 1.0x to 2.0x The default scale level has been 1.0x only on login screen (2.0x on other screens). This changes it into 2.0x, which is consistent with other screens (lock screen and user screen after login). BUG=163147, 163170 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171609

Patch Set 1 #

Total comments: 1

Patch Set 2 : add TODO comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -19 lines) Patch
M ash/magnifier/magnification_controller.cc View 3 chunks +2 lines, -16 lines 0 comments Download
M ash/system/tray_accessibility.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/accessibility/magnification_manager.cc View 1 3 chunks +28 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
yoshiki
@derat: Could you take a look? Thanks,
8 years ago (2012-12-06 15:03:29 UTC) #1
yoshiki
+@zork
8 years ago (2012-12-06 15:15:07 UTC) #2
Daniel Erat
lgtm https://codereview.chromium.org/11442036/diff/1/chrome/browser/chromeos/accessibility/magnification_manager.cc File chrome/browser/chromeos/accessibility/magnification_manager.cc (right): https://codereview.chromium.org/11442036/diff/1/chrome/browser/chromeos/accessibility/magnification_manager.cc#newcode147 chrome/browser/chromeos/accessibility/magnification_manager.cc:147: // screen magnifier pref but no scale pref, ...
8 years ago (2012-12-06 15:15:46 UTC) #3
Nikita (slow)
Works fine on OOBE, thanks!
8 years ago (2012-12-06 15:38:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/11442036/6001
8 years ago (2012-12-06 18:47:55 UTC) #5
commit-bot: I haz the power
8 years ago (2012-12-06 22:35:14 UTC) #6
Message was sent while issue was closed. 
Change committed as 171609

Powered by Google App Engine
This is Rietveld 408576698