Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 11441006: Convert IconManager to use new CancelableTaskTracker (Closed)

Created:
8 years ago by kaiwang
Modified:
8 years ago
Reviewers:
sky
CC:
chromium-reviews, asanka, tfarina, Randy Smith (Not in Mondays), sail+watch_chromium.org, Aaron Boodman, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Convert IconManager to use new CancelableTaskTracker BUG=155883 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171296

Patch Set 1 #

Patch Set 2 : Rebase and fix mac compiling #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -101 lines) Patch
M chrome/browser/extensions/api/downloads/downloads_api.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/icon_manager.h View 3 chunks +17 lines, -19 lines 0 comments Download
M chrome/browser/icon_manager.cc View 4 chunks +33 lines, -18 lines 0 comments Download
M chrome/browser/ui/cocoa/download/download_item_mac.h View 1 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/download/download_item_mac.mm View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/gtk/download/download_item_gtk.h View 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/gtk/download/download_item_gtk.cc View 2 chunks +9 lines, -10 lines 0 comments Download
M chrome/browser/ui/views/download/download_item_view.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/download/download_item_view.cc View 1 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/fileicon_source.h View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/fileicon_source.cc View 4 chunks +15 lines, -17 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kaiwang
8 years ago (2012-12-05 04:00:24 UTC) #1
sky
LGTM
8 years ago (2012-12-05 16:00:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaiwang@chromium.org/11441006/5001
8 years ago (2012-12-05 18:11:54 UTC) #3
commit-bot: I haz the power
8 years ago (2012-12-05 20:26:20 UTC) #4
Message was sent while issue was closed.
Change committed as 171296

Powered by Google App Engine
This is Rietveld 408576698