[Android] Fix AwSettingsTest AppCache test crashes.

[Android] Fix AwSettingsTest AppCache test crashes.

The problem was due to usage of a second cache thread.

R=boliu@chromium.org
BUG=163383
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171520

[boliu, 2012-12-06 15:36:38]

lgtm

+willchan, erikwright for FYI that URLRequestContextBuilder doesn't work well
with app cache.

https://codereview.chromium.org/11440036/diff/1/android_webview/browser/net/a...
File android_webview/browser/net/aw_url_request_context_getter.cc (left):

https://codereview.chromium.org/11440036/diff/1/android_webview/browser/net/a...
android_webview/browser/net/aw_url_request_context_getter.cc:99:
browser_context_->GetPath().Append(FILE_PATH_LITERAL("Cache")),
Unrelated: comma at the end of line...how did this ever compile?

https://codereview.chromium.org/11440036/diff/1/android_webview/browser/net/a...
File android_webview/browser/net/aw_url_request_context_getter.cc (right):

https://codereview.chromium.org/11440036/diff/1/android_webview/browser/net/a...
android_webview/browser/net/aw_url_request_context_getter.cc:108:
net::HttpCache::DefaultBackend* main_backend =
Can we add a TODO or NOTE saying builder doesn't support AppCache yet so we have
to do this.

https://codereview.chromium.org/11440036/diff/1/android_webview/browser/net/a...
android_webview/browser/net/aw_url_request_context_getter.cc:118:
main_http_factory_.reset(main_cache);
nit: combine this line and above so we never declare a local raw pointer

[mnaganov (inactive), 2012-12-06 16:44:55]

Thanks!

https://codereview.chromium.org/11440036/diff/1/android_webview/browser/net/a...
File android_webview/browser/net/aw_url_request_context_getter.cc (left):

https://codereview.chromium.org/11440036/diff/1/android_webview/browser/net/a...
android_webview/browser/net/aw_url_request_context_getter.cc:99:
browser_context_->GetPath().Append(FILE_PATH_LITERAL("Cache")),
On 2012/12/06 15:36:39, boliu wrote:
> Unrelated: comma at the end of line...how did this ever compile?

That's http://en.wikipedia.org/wiki/Comma_operator ! C++ is a magic language.

https://codereview.chromium.org/11440036/diff/1/android_webview/browser/net/a...
File android_webview/browser/net/aw_url_request_context_getter.cc (right):

https://codereview.chromium.org/11440036/diff/1/android_webview/browser/net/a...
android_webview/browser/net/aw_url_request_context_getter.cc:108:
net::HttpCache::DefaultBackend* main_backend =
On 2012/12/06 15:36:39, boliu wrote:
> Can we add a TODO or NOTE saying builder doesn't support AppCache yet so we
have
> to do this.

Done.

https://codereview.chromium.org/11440036/diff/1/android_webview/browser/net/a...
android_webview/browser/net/aw_url_request_context_getter.cc:118:
main_http_factory_.reset(main_cache);
On 2012/12/06 15:36:39, boliu wrote:
> nit: combine this line and above so we never declare a local raw pointer

Done.

[commit-bot: I haz the power, 2012-12-06 16:47:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mnaganov@chromium.org/11440036/9001

[commit-bot: I haz the power, 2012-12-06 17:37:06]

Change committed as 171520

[boliu, 2012-12-06 17:44:02]

https://chromiumcodereview.appspot.com/11440036/diff/1/android_webview/browse...
File android_webview/browser/net/aw_url_request_context_getter.cc (left):

https://chromiumcodereview.appspot.com/11440036/diff/1/android_webview/browse...
android_webview/browser/net/aw_url_request_context_getter.cc:99:
browser_context_->GetPath().Append(FILE_PATH_LITERAL("Cache")),
On 2012/12/06 16:44:56, Mikhail Naganov (Chromium) wrote:
> On 2012/12/06 15:36:39, boliu wrote:
> > Unrelated: comma at the end of line...how did this ever compile?
> 
> That's http://en.wikipedia.org/wiki/Comma_operator ! C++ is a magic language.

Mind blown...