Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3373)

Unified Diff: chrome/browser/upgrade_detector_impl.h

Issue 11440020: Add an outdated upgrade bubble view. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed OWNERS comments... Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/upgrade_detector.cc ('k') | chrome/browser/upgrade_detector_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/upgrade_detector_impl.h
diff --git a/chrome/browser/upgrade_detector_impl.h b/chrome/browser/upgrade_detector_impl.h
index 435d294b662f214c6a3edca76eb124527b723ba8..178d25d84f6805720f023ddb83a4b01cf987ae37 100644
--- a/chrome/browser/upgrade_detector_impl.h
+++ b/chrome/browser/upgrade_detector_impl.h
@@ -23,18 +23,33 @@ class UpgradeDetectorImpl : public UpgradeDetector {
UpgradeDetectorImpl();
+ // Start the timer that will call |CheckForUpgrade()|.
+ void StartTimerForUpgradeCheck();
+
// Launches a task on the file thread to check if we have the latest version.
void CheckForUpgrade();
// Sends out a notification and starts a one shot timer to wait until
// notifying the user.
- void UpgradeDetected();
+ void UpgradeDetected(UpgradeAvailable upgrade_available);
+
+ // Returns true after calling UpgradeDetected if current install is outdated.
+ bool DetectOutdatedInstall();
// The function that sends out a notification (after a certain time has
// elapsed) that lets the rest of the UI know we should start notifying the
// user that a new version is available.
void NotifyOnUpgrade();
+ // Called on the FILE thread to detect an upgrade. Calls back UpgradeDetected
+ // on the UI thread if so. Although it looks weird, this needs to be a static
+ // method receiving a WeakPtr<> to this object so that we can interrupt
+ // the UpgradeDetected callback before it runs. Having this method non-static
+ // and using |this| directly wouldn't be thread safe. And keeping it as a
+ // non-class function would prevent it from calling UpgradeDetected.
+ static void DetectUpgradeTask(
+ base::WeakPtr<UpgradeDetectorImpl> upgrade_detector);
+
// We periodically check to see if Chrome has been upgraded.
base::RepeatingTimer<UpgradeDetectorImpl> detect_upgrade_timer_;
@@ -50,6 +65,9 @@ class UpgradeDetectorImpl : public UpgradeDetector {
// True if this build is a dev or canary channel build.
bool is_unstable_channel_;
+ // The date the binaries were built.
+ base::Time build_date_;
+
DISALLOW_COPY_AND_ASSIGN(UpgradeDetectorImpl);
};
« no previous file with comments | « chrome/browser/upgrade_detector.cc ('k') | chrome/browser/upgrade_detector_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698