Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1337)

Unified Diff: chrome/browser/extensions/extension_messages_apitest.cc

Issue 11440004: Remove deprecated extension EventRouter APIs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: compile Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_devtools_bridge.cc ('k') | chrome/browser/extensions/menu_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_messages_apitest.cc
diff --git a/chrome/browser/extensions/extension_messages_apitest.cc b/chrome/browser/extensions/extension_messages_apitest.cc
index a4c8b30135054696a78f7fe4f010997409aa1d42..af750c22be311f87febf911659fda8af55580c1e 100644
--- a/chrome/browser/extensions/extension_messages_apitest.cc
+++ b/chrome/browser/extensions/extension_messages_apitest.cc
@@ -33,6 +33,17 @@ class MessageSender : public content::NotificationObserver {
return arguments.Pass();
}
+ static scoped_ptr<extensions::Event> BuildEvent(
+ scoped_ptr<ListValue> event_args,
+ Profile* profile,
+ GURL event_url) {
+ scoped_ptr<extensions::Event> event(new extensions::Event(
+ "test.onMessage", event_args.Pass()));
+ event->restrict_to_profile = profile;
+ event->event_url = event_url;
+ return event.Pass();
+ }
+
virtual void Observe(int type,
const content::NotificationSource& source,
const content::NotificationDetails& details) {
@@ -42,26 +53,22 @@ class MessageSender : public content::NotificationObserver {
// Sends four messages to the extension. All but the third message sent
// from the origin http://b.com/ are supposed to arrive.
- event_router->DispatchEventToRenderers("test.onMessage",
+ event_router->BroadcastEvent(BuildEvent(
BuildEventArguments(false, "no restriction"),
content::Source<Profile>(source).ptr(),
- GURL(),
- extensions::EventFilteringInfo());
- event_router->DispatchEventToRenderers("test.onMessage",
+ GURL()));
+ event_router->BroadcastEvent(BuildEvent(
BuildEventArguments(false, "http://a.com/"),
content::Source<Profile>(source).ptr(),
- GURL("http://a.com/"),
- extensions::EventFilteringInfo());
- event_router->DispatchEventToRenderers("test.onMessage",
+ GURL("http://a.com/")));
+ event_router->BroadcastEvent(BuildEvent(
BuildEventArguments(false, "http://b.com/"),
content::Source<Profile>(source).ptr(),
- GURL("http://b.com/"),
- extensions::EventFilteringInfo());
- event_router->DispatchEventToRenderers("test.onMessage",
+ GURL("http://b.com/")));
+ event_router->BroadcastEvent(BuildEvent(
BuildEventArguments(true, "last message"),
content::Source<Profile>(source).ptr(),
- GURL(),
- extensions::EventFilteringInfo());
+ GURL()));
}
content::NotificationRegistrar registrar_;
« no previous file with comments | « chrome/browser/extensions/extension_devtools_bridge.cc ('k') | chrome/browser/extensions/menu_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698