Remove committed check from depot_tools presubmit

presubmit_canned_checks.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Generic presubmit checks that can be reused by other presubmit checks."""
 
 import os as _os
 _HERE = _os.path.dirname(_os.path.abspath(__file__))
 
 
@@ skipping 49 matching lines @@
   """Checks the CL description is not empty."""
   text = input_api.change.DescriptionText()
   if text.strip() == '':
     if input_api.is_committing:
       return [output_api.PresubmitError('Add a description.')]
     else:
       return [output_api.PresubmitNotifyResult('Add a description.')]
   return []
 
 
-def CheckChangeDescriptionNotCommitted(input_api, output_api):
-  """Checks that the CL does not end with a Committed link."""
-  description = input_api.change.DescriptionText()
-  if input_api.re.search('\nCommitted: \S+\s*$', description):
-    return [output_api.PresubmitError(
-      'The CL description appears to end with a committed link. If this issue\n'
-      'has been previously used for a commit, please make a new issue number\n'
-      'by typing "git cl issue 0" and reuploading your CL.')]
-  return []
-
-
 def CheckChangeWasUploaded(input_api, output_api):
   """Checks that the issue was uploaded before committing."""
   if input_api.is_committing and not input_api.change.issue:
     return [output_api.PresubmitError(
       'Issue wasn\'t uploaded. Please upload first.')]
   return []
 
 
 ### Content checks
 
@@ skipping 721 matching lines @@
 
 def CheckIssueNotClosed(input_api, output_api):
   """Verifies issue is not closed.
 
   We should not be working with a closed review. CQ and dcommit set this bit,
   so it is a pretty good indicator of whether an issue has been committed.
   """
   issue_props = _GetRietveldIssueProps(input_api=input_api, messages=False)
   if issue_props and issue_props['closed']:
     return [output_api.PresubmitError(
-        'Issue %s is closed.  If this issue was already used for a commit,\n'
-        'please reset the issue number associated with this branch with:\n'
-        'git cl issue 0\n' % issue_props['issue']
+        'Issue %s is closed.  You can reset the issue number associated with\n'
+        'this branch with: git cl issue 0\n' % issue_props['issue']
         )]
   return []
 
 
 def _RietveldOwnerAndReviewers(input_api, email_regexp, approval_needed=False):
   """Return the owner and reviewers of a change, if any.
 
   If approval_needed is True, only reviewers who have approved the change
   will be returned.
   """
@@ skipping 172 matching lines @@
     results.extend(input_api.canned_checks.CheckLicense(
         input_api, output_api, license_header, source_file_filter=sources))
     snapshot("checking was uploaded")
     results.extend(input_api.canned_checks.CheckChangeWasUploaded(
         input_api, output_api))
     snapshot("checking description")
     results.extend(input_api.canned_checks.CheckChangeHasDescription(
         input_api, output_api))
     results.extend(input_api.canned_checks.CheckDoNotSubmitInDescription(
         input_api, output_api))
-    results.extend(input_api.canned_checks.CheckChangeDescriptionNotCommitted(
-        input_api, output_api))
     snapshot("checking do not submit in files")
     results.extend(input_api.canned_checks.CheckDoNotSubmitInFiles(
         input_api, output_api))
   snapshot("done")
   return results