Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 11434107: QuotaStatusCode: Use enum names instead of hard coding the values (Closed)

Created:
8 years ago by arv (Not doing code reviews)
Modified:
8 years ago
Reviewers:
michaeln
CC:
chromium-reviews, darin-cc_chromium.org, jsbell
Visibility:
Public.

Description

QuotaStatusCode: Use enum names instead of hard coding the values This is blocking https://bugs.webkit.org/show_bug.cgi?id=102726 since QuotaStatusCode hard codes the values which prevents us from changing those values. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171133

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M webkit/quota/quota_status_code.h View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
arv (Not doing code reviews)
8 years ago (2012-12-04 17:52:10 UTC) #1
arv (Not doing code reviews)
kinuko, do you mind taking a look?
8 years ago (2012-12-04 20:52:28 UTC) #2
michaeln
lgtm
8 years ago (2012-12-04 23:32:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arv@chromium.org/11434107/1
8 years ago (2012-12-04 23:37:16 UTC) #4
commit-bot: I haz the power
Change committed as 171133
8 years ago (2012-12-05 02:45:32 UTC) #5
kinuko
8 years ago (2012-12-05 04:50:14 UTC) #6
Message was sent while issue was closed.
yup, lgtm!

Powered by Google App Engine
This is Rietveld 408576698