Use the correct launcher assets for shelf alignment.

Use the correct launcher assets for shelf alignment.

Cleanup: remove redundant shelf code.
- replaces switch to get values for alignment with template
- eliminate alignment member variables and use shelf_layout_manager where possible.

other minor clean ups: remove unnecessary namespace, use member variable.

BUG=151417
TEST=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171120

[sky, 2012-12-04 17:06:03]

https://codereview.chromium.org/11434099/diff/5031/ash/launcher/launcher_butt...
File ash/launcher/launcher_button.cc (right):

https://codereview.chromium.org/11434099/diff/5031/ash/launcher/launcher_butt...
ash/launcher/launcher_button.cc:416: bar_->Layout();
Can this be bar_->InvalidateLayout()?

[oshima, 2012-12-04 17:24:29]

https://codereview.chromium.org/11434099/diff/5031/ash/launcher/launcher_butt...
File ash/launcher/launcher_button.cc (right):

https://codereview.chromium.org/11434099/diff/5031/ash/launcher/launcher_butt...
ash/launcher/launcher_button.cc:416: bar_->Layout();
On 2012/12/04 17:06:03, sky wrote:
> Can this be bar_->InvalidateLayout()?

Yes, it can (next "Layout()" will re-layout it).
It has one side effect though. It invalidates all parents,
which isn't really necessary because we know the parent (this button). I don't
have strong opinion, so please let me know
which you like.

[sky, 2012-12-04 17:59:43]

Good point, leave it as you have it. LGTM

[commit-bot: I haz the power, 2012-12-04 22:21:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/11434099/2024

[commit-bot: I haz the power, 2012-12-05 01:47:24]

Change committed as 171120