Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 11434093: Add ffmpegsumo.dll to 'symsrc' group for symbol upload. (Closed)

Created:
8 years ago by DaleCurtis
Modified:
8 years ago
Reviewers:
Michael Moss
CC:
chromium-reviews, pam+watch_chromium.org, scherkus (not reviewing)
Visibility:
Public.

Description

Add ffmpegsumo.dll to 'symsrc' group for symbol upload. BUG=164036 TEST=none NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170830

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/tools/build/win/FILES.cfg View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
DaleCurtis
mmoss: scherkus mentioned that he got an error about loading symbols from the symbol server ...
8 years ago (2012-12-03 22:08:01 UTC) #1
Michael Moss
LGTM. I'm not positive how the Windows symbol server debugging works, but yes, I think ...
8 years ago (2012-12-03 22:16:23 UTC) #2
DaleCurtis
Will this affect crash reporting? If so, should I have this merged to M24?
8 years ago (2012-12-03 22:17:51 UTC) #3
Michael Moss
I'm not sure if it affects crash reporting, but it probably wouldn't hurt to merge ...
8 years ago (2012-12-03 22:27:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/11434093/1
8 years ago (2012-12-03 22:36:44 UTC) #5
commit-bot: I haz the power
8 years ago (2012-12-03 22:38:11 UTC) #6
Message was sent while issue was closed.
Change committed as 170830

Powered by Google App Engine
This is Rietveld 408576698