Issue 11434076: Encrypted Media: Check WebKit::WebRuntimeFeatures::isEncryptedMediaEnabled() in WebMediaPlayerImpl.

Issue 11434076: Encrypted Media: Check WebKit::WebRuntimeFeatures::isEncryptedMediaEnabled() in WebMediaPlayerImpl. (Closed)

Created:
8 years ago by xhwang

Modified:
8 years ago

Reviewers:
ddorwin, scherkus (not reviewing)

CC:
chromium-reviews, feature-media-reviews_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Encrypted Media: Check WebKit::WebRuntimeFeatures::isEncryptedMediaEnabled() in WebMediaPlayerImpl. Check WebKit::WebRuntimeFeatures::isEncryptedMediaEnabled() instead of chromium switch because in LayoutTest chromium switch is not used. BUG=163785 TEST=LayoutTest Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171039

Patch Set 1 #

Total comments: 4

Patch Set 2 : remove headers that we don't use #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -4 lines)			Patch
	M	webkit/media/webmediaplayer_impl.cc	View	1	3 chunks	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

scherkus (not reviewing)

https://codereview.chromium.org/11434076/diff/1/webkit/media/webmediaplayer_impl.cc File webkit/media/webmediaplayer_impl.cc (right): https://codereview.chromium.org/11434076/diff/1/webkit/media/webmediaplayer_impl.cc#newcode13 webkit/media/webmediaplayer_impl.cc:13: #include "base/command_line.h" afaik not used anymore https://codereview.chromium.org/11434076/diff/1/webkit/media/webmediaplayer_impl.cc#newcode191 webkit/media/webmediaplayer_impl.cc:191: if ...

8 years ago (2012-12-04 18:13:04 UTC) #3

xhwang

PTAL again! https://codereview.chromium.org/11434076/diff/1/webkit/media/webmediaplayer_impl.cc File webkit/media/webmediaplayer_impl.cc (right): https://codereview.chromium.org/11434076/diff/1/webkit/media/webmediaplayer_impl.cc#newcode13 webkit/media/webmediaplayer_impl.cc:13: #include "base/command_line.h" On 2012/12/04 18:13:04, scherkus wrote: ...

8 years ago (2012-12-04 18:25:20 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/11434076/6001

8 years ago (2012-12-04 18:32:19 UTC) #6

Message was sent while issue was closed.

Change committed as 171039

Expand Messages | Collapse Messages