Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11434074: browser: Move FindBrowserWithWebContents() into chrome namespace. (Closed)

Created:
8 years ago by tfarina
Modified:
8 years ago
CC:
chromium-reviews, Avi (use Gerrit), groby+watch_chromium.org, creis+watch_chromium.org, akalin, tfarina, Raghu Simha, kkania, sail+watch_chromium.org, robertshield, ajwong+watch_chromium.org, gbillock+watch_chromium.org, smckay+watch_chromium.org, haitaol1, rouslan+watch_chromium.org, tim (not reviewing)
Visibility:
Public.

Description

browser: Move FindBrowserWithWebContents() into chrome namespace. BUG=133088 TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170686

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -87 lines) Patch
M chrome/browser/automation/automation_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/captive_portal/captive_portal_tab_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/app_notify_channel_ui_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_tab_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/first_run/first_run.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/history_tab_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/managed_mode/managed_mode_navigation_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/omnibox_search_hint.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_preview_tab_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/session_restore.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/tab_contents/web_drag_bookmark_handler_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/web_drag_bookmark_handler_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/web_drag_bookmark_handler_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/web_drag_bookmark_handler_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/translate/translate_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_browser.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_finder.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/browser_finder.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/browser_tab_restore_service_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_mac2.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/infobars/extension_infobar_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/intents/web_intent_inline_service_view_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_icon_decoration.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/create_application_shortcuts_dialog_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/password_generation_bubble_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/speech_recognition_bubble_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/web_intent_picker_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/intents/web_intent_picker_controller.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/pdf/pdf_tab_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/search/other_device_menu_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/startup/default_browser_prompt_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/startup/session_crashed_prompt.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/sync/one_click_signin_helper.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/create_application_shortcut_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/sad_tab_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/speech_recognition_bubble_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/web_intent_picker_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chrome_web_contents_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/help/help_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/history_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/app_launcher_handler.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_page_sync_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_login_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/import_data_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/manage_profile_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/sync_promo/sync_promo_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/sync_setup_handler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
tfarina
TBRing...
8 years ago (2012-12-01 20:55:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/11434074/3011
8 years ago (2012-12-01 20:56:21 UTC) #2
Ben Goodger (Google)
lgtm
8 years ago (2012-12-02 02:20:44 UTC) #3
commit-bot: I haz the power
8 years ago (2012-12-02 07:43:20 UTC) #4
Message was sent while issue was closed. 
Change committed as 170686

Powered by Google App Engine
This is Rietveld 408576698