allow spaces on the per-file directives in OWNERS files

allow spaces on the per-file directives in OWNERS files

R=maruel@chromium.org
BUG=163030
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=170819

[M-A Ruel, 2012-11-30 18:37:31]

in fact, I don't really a preference, as-is is fine.

lgtm

https://codereview.chromium.org/11434048/diff/1/owners.py
File owners.py (right):

https://codereview.chromium.org/11434048/diff/1/owners.py#newcode222
owners.py:222: m = re.match("per-file (.+)=(.+)", line)
why not
re.match(r"per-file\s+(.+)\s*=\s*(.+)\s*", line)

[Dirk Pranke, 2012-11-30 20:02:17]

On 2012/11/30 18:37:31, Marc-Antoine Ruel wrote:
> in fact, I don't really a preference, as-is is fine.
> 
> lgtm
> 
> https://codereview.chromium.org/11434048/diff/1/owners.py
> File owners.py (right):
> 
> https://codereview.chromium.org/11434048/diff/1/owners.py#newcode222
> owners.py:222: m = re.match("per-file (.+)=(.+)", line)
> why not
> re.match(r"per-file\s+(.+)\s*=\s*(.+)\s*", line)

Fair question. I waffled on it myself, but thought the way I did it was slightly
easier to follow. I tend to try and keep regexps as simple as possible so that
they're easier to read, but it's pretty much a toss-up in this case.

[M-A Ruel, 2012-11-30 20:15:25]

On 2012/11/30 20:02:17, Dirk Pranke wrote:
> On 2012/11/30 18:37:31, Marc-Antoine Ruel wrote:
> > in fact, I don't really a preference, as-is is fine.
> > 
> > lgtm
> > 
> > https://codereview.chromium.org/11434048/diff/1/owners.py
> > File owners.py (right):
> > 
> > https://codereview.chromium.org/11434048/diff/1/owners.py#newcode222
> > owners.py:222: m = re.match("per-file (.+)=(.+)", line)
> > why not
> > re.match(r"per-file\s+(.+)\s*=\s*(.+)\s*", line)
> 
> Fair question. I waffled on it myself, but thought the way I did it was
slightly
> easier to follow. I tend to try and keep regexps as simple as possible so that
> they're easier to read, but it's pretty much a toss-up in this case.

Don't bother.

[commit-bot: I haz the power, 2012-12-03 21:50:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dpranke@chromium.org/11434048/1

[commit-bot: I haz the power, 2012-12-03 21:53:51]

Change committed as 170819