Remove duplicate words from custom spelling dictionary on load

Remove duplicate words from custom spelling dictionary on load

BUG=51636
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170540

[please use gerrit instead, 2012-11-29 23:23:19]

Rachel - chrome/browser/spellchecker
Chris - chrome/browser/ui/webui/options

[groby-ooo-7-16, 2012-11-29 23:35:47]

LGTM w/nits

https://codereview.chromium.org/11434043/diff/1/chrome/browser/spellchecker/s...
File chrome/browser/spellchecker/spellcheck_custom_dictionary.cc (right):

https://codereview.chromium.org/11434043/diff/1/chrome/browser/spellchecker/s...
chrome/browser/spellchecker/spellcheck_custom_dictionary.cc:65:
custom_words->resize(it - custom_words->begin());
nit: Use custom_words.erase instead - erase(unique(....)) is a standard idiom.

https://codereview.chromium.org/11434043/diff/1/chrome/browser/spellchecker/s...
chrome/browser/spellchecker/spellcheck_custom_dictionary.cc:74: char separator[]
= {'\n', '\0'};
const char

https://codereview.chromium.org/11434043/diff/1/chrome/browser/spellchecker/s...
chrome/browser/spellchecker/spellcheck_custom_dictionary.cc:79:
ss.write(word.c_str(), word.length());
ss << *it << separator; // Why not this?

https://codereview.chromium.org/11434043/diff/1/chrome/browser/spellchecker/s...
File chrome/browser/spellchecker/spellcheck_custom_dictionary.h (right):

https://codereview.chromium.org/11434043/diff/1/chrome/browser/spellchecker/s...
chrome/browser/spellchecker/spellcheck_custom_dictionary.h:35: // Populates the
given vector with the list of words in the custom dictionary
Populates |custom_words|...

[please use gerrit instead, 2012-11-29 23:48:03]

Addressed Rachel's comments.

https://codereview.chromium.org/11434043/diff/1/chrome/browser/spellchecker/s...
File chrome/browser/spellchecker/spellcheck_custom_dictionary.cc (right):

https://codereview.chromium.org/11434043/diff/1/chrome/browser/spellchecker/s...
chrome/browser/spellchecker/spellcheck_custom_dictionary.cc:65:
custom_words->resize(it - custom_words->begin());
On 2012/11/29 23:35:47, groby wrote:
> nit: Use custom_words.erase instead - erase(unique(....)) is a standard idiom.


Done.

https://codereview.chromium.org/11434043/diff/1/chrome/browser/spellchecker/s...
chrome/browser/spellchecker/spellcheck_custom_dictionary.cc:74: char separator[]
= {'\n', '\0'};
On 2012/11/29 23:35:47, groby wrote:
> const char

Done.

https://codereview.chromium.org/11434043/diff/1/chrome/browser/spellchecker/s...
chrome/browser/spellchecker/spellcheck_custom_dictionary.cc:79:
ss.write(word.c_str(), word.length());
On 2012/11/29 23:35:47, groby wrote:
> ss << *it << separator; // Why not this?

Done.

https://codereview.chromium.org/11434043/diff/1/chrome/browser/spellchecker/s...
File chrome/browser/spellchecker/spellcheck_custom_dictionary.h (right):

https://codereview.chromium.org/11434043/diff/1/chrome/browser/spellchecker/s...
chrome/browser/spellchecker/spellcheck_custom_dictionary.h:35: // Populates the
given vector with the list of words in the custom dictionary
On 2012/11/29 23:35:47, groby wrote:
> Populates |custom_words|...

Done.

[csilv, 2012-11-30 18:35:33]

lgtm

[commit-bot: I haz the power, 2012-11-30 18:40:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rouslan@chromium.org/11434043/5001

[commit-bot: I haz the power, 2012-11-30 19:19:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rouslan@chromium.org/11434043/4005

[commit-bot: I haz the power, 2012-11-30 21:17:01]

Change committed as 170540