Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 11434042: PPAPI: Hook up Browser resource host stuff for NaCl (Closed)

Created:
8 years ago by dmichael (off chromium)
Modified:
8 years ago
Reviewers:
brettw
CC:
chromium-reviews, bbudge
Visibility:
Public.

Description

PPAPI: Hook up Browser resource host stuff for NaCl This does not fix handle passing, but messages that don't carry handles will probably work. BUG=163021, 163861 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171025

Patch Set 1 #

Patch Set 2 : more fixes, more debug output junk #

Patch Set 3 : More fixes, now shmem mapping fails #

Patch Set 4 : Remove debugging and handle conversion #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M chrome/browser/nacl_host/nacl_process_host.cc View 1 2 3 1 chunk +4 lines, -3 lines 0 comments Download
M content/browser/renderer_host/pepper/browser_ppapi_host_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/proxy/plugin_main_nacl.cc View 1 2 3 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
dmichael (off chromium)
8 years ago (2012-12-03 23:48:23 UTC) #1
dmichael (off chromium)
+ygorshenin FYI. Let me know if this helps.
8 years ago (2012-12-03 23:51:04 UTC) #2
brettw
lgtm
8 years ago (2012-12-04 00:17:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/11434042/5003
8 years ago (2012-12-04 01:44:56 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
8 years ago (2012-12-04 03:05:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/11434042/5003
8 years ago (2012-12-04 17:29:38 UTC) #6
commit-bot: I haz the power
Change committed as 171025
8 years ago (2012-12-04 19:37:50 UTC) #7
ygorshenin1
8 years ago (2012-12-05 07:26:51 UTC) #8
Message was sent while issue was closed.
On 2012/12/03 23:51:04, dmichael wrote:
> +ygorshenin FYI. Let me know if this helps.

Many thanks Dave, it helps --- NaCl UDP works now.

Powered by Google App Engine
This is Rietveld 408576698