[telemetry] Number the trace .json files in trace-dir.

[telemetry] Number the trace .json files in trace-dir.

Currently if you reuse the same trace-dir, your previous traces will be
overwritten. This will number the outputs. Particularly useful if you use
the repeat flags (--page-repeat, --pageset-repeat). See if you like the idea.

Also contains a minor fix to the repeat flags, which didn't convert the input
value to int before trying to use it.

BUG=None


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170676

[hartmanng, 2012-11-29 19:50:10]

Please take a look

[dtu, 2012-11-30 02:03:56]

Can we also have one number to represent the entire run? I'm worried about
getting jumbled numbers if you stop a run halfway through or have different page
sets with some overlapping pages.

[nduca, 2012-11-30 02:17:07]

This may make sense with repeat count, but not sure i buy it when its one page
at a time.

If you told it to trace to a dir, then it should go to a predictable place.

[nduca, 2012-11-30 02:17:23]

Think about the implication of this on a bot, for example.

[nduca, 2012-11-30 02:17:47]

I'd rather we fail if the trace dir is non-empty

[hartmanng, 2012-11-30 19:51:35]

On 2012/11/30 02:17:47, nduca wrote:
> I'd rather we fail if the trace dir is non-empty

Ok how about this approach:

We fail up-front if the specified dir is non-empty. Assuming it is empty, we
will append a count to the output if and only if page_repeat or pageset_repeat
have been set with custom values.

This should make it simple for bots - assuming it doesn't exit because of a
non-empty dir, it will always put the output trace files in the same place, no
worrying about numbers at the end.

On the other hand, if we actually want several sets of output, we can specify
page_repeat or pageset_repeat and nothing will have to get overwritten.

Jumbling numbers should also not be a problem since it will exit if we try to
run it a second time with a non-empty dir.

PTAL

[nduca, 2012-11-30 20:16:03]

Thats fantastic. Dtu for the review. Its important that these things are
determnistic. As long as thats true, I'm happy.

[dtu, 2012-12-01 01:22:14]

lgtm with nit

https://chromiumcodereview.appspot.com/11434040/diff/4002/tools/telemetry/tel...
File tools/telemetry/telemetry/page_runner.py (right):

https://chromiumcodereview.appspot.com/11434040/diff/4002/tools/telemetry/tel...
tools/telemetry/telemetry/page_runner.py:175: trace_file = "%s_%03d.json" %
(trace_file_base, trace_file_index)
Single quotes. Below too.

[commit-bot: I haz the power, 2012-12-01 18:16:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hartmanng@chromium.org/11434040/9001

[commit-bot: I haz the power, 2012-12-01 20:26:45]

Change committed as 170676