Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Unified Diff: components/guest_view/browser/guest_view_message_filter.h

Issue 1143333008: Getting rid of more webview memory leaks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/guest_view/browser/guest_view_message_filter.h
diff --git a/components/guest_view/browser/guest_view_message_filter.h b/components/guest_view/browser/guest_view_message_filter.h
index 50b94e839b00eb71d6238c65dc7d4d9ba7230108..163945b68876c7dae88b0ae49bd0bb88dcd512b6 100644
--- a/components/guest_view/browser/guest_view_message_filter.h
+++ b/components/guest_view/browser/guest_view_message_filter.h
@@ -53,9 +53,6 @@ class GuestViewMessageFilter : public content::BrowserMessageFilter {
void OnDestruct() const override;
bool OnMessageReceived(const IPC::Message& message) override;
- // Message handlers on the UI thread.
- void OnViewGarbageCollected(int view_instance_id);
-
const int render_process_id_;
// Should only be accessed on the UI thread.
@@ -72,6 +69,8 @@ class GuestViewMessageFilter : public content::BrowserMessageFilter {
void OnAttachGuest(int element_instance_id,
int guest_instance_id,
const base::DictionaryValue& attach_params);
+ void OnViewCreated(int view_instance_id, const std::string& view_type);
+ void OnViewGarbageCollected(int view_instance_id);
DISALLOW_COPY_AND_ASSIGN(GuestViewMessageFilter);
};

Powered by Google App Engine
This is Rietveld 408576698