Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2672)

Unified Diff: extensions/browser/guest_view/web_view/web_view_guest.h

Issue 1143333008: Getting rid of more webview memory leaks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/web_view/web_view_guest.h
diff --git a/extensions/browser/guest_view/web_view/web_view_guest.h b/extensions/browser/guest_view/web_view/web_view_guest.h
index 517c1db5095b46150adc5cabcdfd314e1876b903..08bd0602920a6b827d22376a509a56e4bdfddb30 100644
--- a/extensions/browser/guest_view/web_view/web_view_guest.h
+++ b/extensions/browser/guest_view/web_view/web_view_guest.h
@@ -36,6 +36,10 @@ class WebViewInternalFindFunction;
class WebViewGuest : public guest_view::GuestView<WebViewGuest>,
public content::NotificationObserver {
public:
+ // Clean up state when this GuestView is being destroyed. See
+ // GuestViewBase::CleanUp().
+ static void CleanUp(int embedder_process_id, int view_instance_id);
+
static GuestViewBase* Create(content::WebContents* owner_web_contents);
// For WebViewGuest, we create special guest processes, which host the
@@ -110,7 +114,6 @@ class WebViewGuest : public guest_view::GuestView<WebViewGuest>,
void DidInitialize(const base::DictionaryValue& create_params) override;
void GuestViewDidStopLoading() override;
void EmbedderFullscreenToggled(bool entered_fullscreen) override;
- void EmbedderWillBeDestroyed() override;
const char* GetAPINamespace() const override;
int GetTaskPrefix() const override;
void GuestDestroyed() override;

Powered by Google App Engine
This is Rietveld 408576698