Source/modules/fetch/FetchManager.cpp - Issue 1143083002: Implement request's redirect mode and RequestRedirect for Fetch

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/fetch/FetchManager.cpp

Issue 1143083002: Implement request's redirect mode and RequestRedirect for Fetch (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/serviceworker/resources/fetch-request-xhr-worker.js ('k') | Source/modules/fetch/FetchRequestData.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/fetch/FetchManager.cpp

diff --git a/Source/modules/fetch/FetchManager.cpp b/Source/modules/fetch/FetchManager.cpp

index 29b2f61ea1404304127a1d3fe565bbd53ff39aa9..27644d211257aef6af01557fc1afb3bfecbd6463 100644

--- a/Source/modules/fetch/FetchManager.cpp

+++ b/Source/modules/fetch/FetchManager.cpp

@@ -285,6 +285,7 @@ void FetchManager::Loader::start()

|| m_request->headerList()->containsNonSimpleHeader()))) {

// "Set |request|'s response tainting to |CORS|."

m_request->setResponseTainting(FetchRequestData::CORSTainting);

+ m_request->setRedirect(WebURLRequest::FetchRedirectModeError);

// "The result of performing an HTTP fetch using |request| with the

// |CORS flag| and |CORS preflight flag| set."

performHTTPFetch(true, true);

@@ -361,6 +362,7 @@ void FetchManager::Loader::performHTTPFetch(bool corsFlag, bool corsPreflightFla

// FIXME: Support body.

ResourceRequest request(m_request->url());

request.setRequestContext(m_request->context());

+ request.setFetchRedirectMode(m_request->redirect());

request.setHTTPMethod(m_request->method());

const Vector<OwnPtr<FetchHeaderList::Header>>& list = m_request->headerList()->list();

for (size_t i = 0; i < list.size(); ++i) {