Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 11428142: Remove extern keyword in definition (Closed)

Created:
8 years ago by simonhong_
Modified:
8 years ago
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Remove extern keyword in definition For consistency with other definition in the same file. Extern declaration already did in chrome_constants.h BUG=NONE TEST=Compiles Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170940

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/common/chrome_constants.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
simonhong_
Dear Ben, Please review this patch. Thank you.
8 years ago (2012-12-03 18:44:46 UTC) #1
Ben Goodger (Google)
lgtm
8 years ago (2012-12-03 18:46:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simon.hong81@gmail.com/11428142/1
8 years ago (2012-12-03 19:01:56 UTC) #3
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests
8 years ago (2012-12-03 23:45:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simon.hong81@gmail.com/11428142/1
8 years ago (2012-12-04 00:12:08 UTC) #5
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests
8 years ago (2012-12-04 04:47:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simon.hong81@gmail.com/11428142/1
8 years ago (2012-12-04 05:38:33 UTC) #7
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests
8 years ago (2012-12-04 08:52:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simon.hong81@gmail.com/11428142/1
8 years ago (2012-12-04 10:59:52 UTC) #9
commit-bot: I haz the power
8 years ago (2012-12-04 12:08:56 UTC) #10
Message was sent while issue was closed.
Change committed as 170940

Powered by Google App Engine
This is Rietveld 408576698