ARM: Make use of d16-d31 when available.

src/isolate.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 1981 matching lines @@
   }
 
   if (create_heap_objects) {
     // Terminate the cache array with the sentinel so we can iterate.
     PushToPartialSnapshotCache(heap_.undefined_value());
   }
 
   InitializeThreadLocal();
 
   bootstrapper_->Initialize(create_heap_objects);
-  builtins_.SetUp(create_heap_objects);
+  builtins_.SetUp(create_heap_objects, false);
 
   // Only preallocate on the first initialization.
   if (FLAG_preallocate_message_memory && preallocated_message_space_ == NULL) {
     // Start the thread which will set aside some memory.
     PreallocatedMemoryThreadStart();
     preallocated_message_space_ =
         new NoAllocationStringAllocator(
             preallocated_memory_thread_->data(),
             preallocated_memory_thread_->length());
     PreallocatedStorageInit(preallocated_memory_thread_->length() / 4);
   }
 
   if (FLAG_preemption) {
     v8::Locker locker;
     v8::Locker::StartPreemption(100);
   }
 
 #ifdef ENABLE_DEBUGGER_SUPPORT
   debug_->SetUp(create_heap_objects);
 #endif
 
   // If we are deserializing, read the state into the now-empty heap.
   if (!create_heap_objects) {
     des->Deserialize();
+
+    // Set up builtins that are not included in snapshot.
+    builtins_.SetUp(false, true);

[ulan, 2012/12/17 10:44:52]

This doesn't cover the case when snapshot is completely disabled (can be tested
with "make snapshot=off" command). In this case create_heap_objects will be
true, but Serializer()::enabled() will be false, and we will miss generating
non-snapshot builtins.

What if we combine the two flag arguments of the SetUp() into an enum with
descriptive names, e.g. (maybe there are better names):
GENERATE_FOR_SNAPSHOT, GENERATE_ALL, GENERATE_BEFORE_DESERIALIZATION,
GENERATE_AFTER_DESERIALIZATION.

Then we can call SetUp with the correct argument depending on
create_heap_objects, Serializer()::enabled().

[hans, 2012/12/17 12:31:44]

That sounds like a good idea.

[ulan, 2012/12/17 13:03:36]

Thanks, this part looks good now.
On 2012/12/17 12:31:44, hans wrote:

   }
+
   stub_cache_->Initialize();
 
   // Finish initialization of ThreadLocal after deserialization is done.
   clear_pending_exception();
   clear_pending_message();
   clear_scheduled_exception();
 
   // Deserializing may put strange things in the root array's copy of the
   // stack guard.
   heap_.SetStackLimits();
@@ skipping 139 matching lines @@
 
 #ifdef DEBUG
 #define ISOLATE_FIELD_OFFSET(type, name, ignored)                       \
 const intptr_t Isolate::name##_debug_offset_ = OFFSET_OF(Isolate, name##_);
 ISOLATE_INIT_LIST(ISOLATE_FIELD_OFFSET)
 ISOLATE_INIT_ARRAY_LIST(ISOLATE_FIELD_OFFSET)
 #undef ISOLATE_FIELD_OFFSET
 #endif
 
 } }  // namespace v8::internal