[Sync] Fix auth error handling while the backend is initializing.

[Sync] Fix auth error handling while the backend is initializing.

This changes it so that we no longer throw an unrecoverable error if we get an
auth error while bringing up the backend (which can happen if we fail to
download control types). We now let just let the backend continuing retrying
(in backoff mode), until the user resolves the auth error, at which point
we'll perform our pending sync cycle, finishing backend initialization.

BUG=163491
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171094

[Nicolas Zea, 2012-12-01 01:04:25]

PTAL

[tim (not reviewing), 2012-12-04 18:47:24]

https://codereview.chromium.org/11428125/diff/1/chrome/browser/sync/profile_s...
File chrome/browser/sync/profile_sync_service.cc (right):

https://codereview.chromium.org/11428125/diff/1/chrome/browser/sync/profile_s...
chrome/browser/sync/profile_sync_service.cc:1633: DCHECK(backend_.get());
This scares me, given that it's contrary to the idea of making downloading
encryption information part of sync backend initialization, and
ProfileSyncService is the thing that caches passphrases (not the backend).

https://codereview.chromium.org/11428125/diff/1/chrome/browser/sync/test_prof...
File chrome/browser/sync/test_profile_sync_service.h (right):

https://codereview.chromium.org/11428125/diff/1/chrome/browser/sync/test_prof...
chrome/browser/sync/test_profile_sync_service.h:93: base::Closure
initial_download_closure_;
How is this different from |callback_|?

[Nicolas Zea, 2012-12-04 19:22:58]

PTAL

https://codereview.chromium.org/11428125/diff/1/chrome/browser/sync/profile_s...
File chrome/browser/sync/profile_sync_service.cc (right):

https://codereview.chromium.org/11428125/diff/1/chrome/browser/sync/profile_s...
chrome/browser/sync/profile_sync_service.cc:1633: DCHECK(backend_.get());
On 2012/12/04 18:47:24, timsteele wrote:
> This scares me, given that it's contrary to the idea of making downloading
> encryption information part of sync backend initialization, and
> ProfileSyncService is the thing that caches passphrases (not the backend).

Hmm, I guess I can actually leave this the same as before. Done.

https://codereview.chromium.org/11428125/diff/1/chrome/browser/sync/test_prof...
File chrome/browser/sync/test_profile_sync_service.h (right):

https://codereview.chromium.org/11428125/diff/1/chrome/browser/sync/test_prof...
chrome/browser/sync/test_profile_sync_service.h:93: base::Closure
initial_download_closure_;
On 2012/12/04 18:47:24, timsteele wrote:
> How is this different from |callback_|?

initial_download_closure is invoked after callback_, and only if
fail_initial_download_ was true. It's just a holder for storing the result of
initialization until we receive new credentials, while callback_ allows the test
to specify extra work to do.

Reordered the variable declaration and added comments to make that more clear.

[tim (not reviewing), 2012-12-04 19:27:35]

LGTM

[commit-bot: I haz the power, 2012-12-04 19:31:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zea@chromium.org/11428125/6005

[commit-bot: I haz the power, 2012-12-04 19:50:15]

Sorry for I got bad news for ya.
Compile failed with a clobber build on ios_rel_device.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_rel_de...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-12-04 19:53:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zea@chromium.org/11428125/13002

[commit-bot: I haz the power, 2012-12-05 00:29:55]

Change committed as 171094