Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(895)

Issue 11428117: Fix compile warnings for 64-bit constants. (Closed)

Created:
8 years ago by Ilya Sherman
Modified:
8 years ago
Reviewers:
danakj, Ryan Sleevi
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

Fix compile warnings for 64-bit constants. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170601

Patch Set 1 #

Total comments: 2

Patch Set 2 : GG_LONGLONG -> GG_INT64_C #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M cc/hash_pair_unittest.cc View 1 5 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Ilya Sherman
8 years ago (2012-11-30 20:31:12 UTC) #1
danakj
lgtm
8 years ago (2012-11-30 20:34:20 UTC) #2
Ryan Sleevi
LGTM, mod macro switch below. https://chromiumcodereview.appspot.com/11428117/diff/1/cc/hash_pair_unittest.cc File cc/hash_pair_unittest.cc (right): https://chromiumcodereview.appspot.com/11428117/diff/1/cc/hash_pair_unittest.cc#newcode34 cc/hash_pair_unittest.cc:34: (GG_LONGLONG(1) << 60) + ...
8 years ago (2012-11-30 20:35:15 UTC) #3
Ilya Sherman
https://chromiumcodereview.appspot.com/11428117/diff/1/cc/hash_pair_unittest.cc File cc/hash_pair_unittest.cc (right): https://chromiumcodereview.appspot.com/11428117/diff/1/cc/hash_pair_unittest.cc#newcode34 cc/hash_pair_unittest.cc:34: (GG_LONGLONG(1) << 60) + GG_LONGLONG(78931732321)); On 2012/11/30 20:35:15, Ryan ...
8 years ago (2012-11-30 21:06:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/11428117/5001
8 years ago (2012-11-30 21:07:47 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_aura for step(s) aura_unittests, content_browsertests, content_unittests, views_unittests
8 years ago (2012-11-30 21:28:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/11428117/5001
8 years ago (2012-11-30 21:30:30 UTC) #7
commit-bot: I haz the power
8 years ago (2012-11-30 23:49:43 UTC) #8
Message was sent while issue was closed.
Change committed as 170601

Powered by Google App Engine
This is Rietveld 408576698