[NaCl SDK] Fix zip_test failure on mac buildbots.

[NaCl SDK] Fix zip_test failure on mac buildbots.

The mac buildbots use an older version of python 2.6 that doesn't support
adding directories to zipfiles. Work around it by adding an empty file with the
same zip path (which is basically what later versions do anyway).

BUG=none
R=sbc@chromium.org
TBR=noelallen@chromium.org
NOTRY=true


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170564

[Sam Clegg, 2012-11-30 19:01:43]

https://codereview.chromium.org/11428111/diff/1/native_client_sdk/src/tools/o...
File native_client_sdk/src/tools/oshelpers.py (right):

https://codereview.chromium.org/11428111/diff/1/native_client_sdk/src/tools/o...
native_client_sdk/src/tools/oshelpers.py:434: zip_stream.writestr(zip_path, '')
Are you sure this is all it does?  Surly there is a difference between an empty
file and a folder in the zip
format?

Looking at the code it look like it at least adds a trailing
slash.

[binji, 2012-11-30 19:43:42]

https://codereview.chromium.org/11428111/diff/1/native_client_sdk/src/tools/o...
File native_client_sdk/src/tools/oshelpers.py (right):

https://codereview.chromium.org/11428111/diff/1/native_client_sdk/src/tools/o...
native_client_sdk/src/tools/oshelpers.py:434: zip_stream.writestr(zip_path, '')
On 2012/11/30 19:01:43, Sam Clegg wrote:
> Are you sure this is all it does?  Surly there is a difference between an
empty
> file and a folder in the zip
> format?

Doesn't seem to be. Though I am writing some of the ZipInfo differently this
way. I've uploaded a new patch with those changes.

> 
> Looking at the code it look like it at least adds a trailing
> slash.

Yes, but I already handle that using MakeZipPath above.

[Sam Clegg, 2012-11-30 20:07:43]

lgtm

[commit-bot: I haz the power, 2012-11-30 21:59:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/binji@chromium.org/11428111/5001

[commit-bot: I haz the power, 2012-11-30 22:00:02]

Change committed as 170564