Issue 11428085: Fix couple of issues in ExtensionCrashRecoveryTest. In particular the

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11428085: Fix couple of issues in ExtensionCrashRecoveryTest. In particular the (Closed)

Created:
8 years ago by sky

Modified:
8 years ago

Reviewers:
Matt Perry

CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@extension_crash

Visibility:
Public.

Fix couple of issues in ExtensionCrashRecoveryTest. In particular the code assumes the there are a certain number of notifications, which means if there aren't the test crashes. The ASSERTS I'm adding should give better error reporting. BUG=163196 TEST=none R=mpcomplete@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170263

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -19 lines)			Patch
	M	chrome/browser/extensions/extension_crash_recovery_browsertest.cc	View		11 chunks	+21 lines, -19 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/11428085/1

8 years ago (2012-11-29 20:29:49 UTC) #3

Message was sent while issue was closed.

Change committed as 170263