NTP5: Implementing two rows option for Apps.

NTP5: Implementing two rows option for Apps:
  - Apps content now will display 2 rows of Apps when there's enough vertical space
  - App styling/spacing has been tweaked
  - Margin of some elements replaced with padding so we can use offsetHeight to dynamically calculate the fixed height of the Bottom Panel (header + footer)

This CL depends on https://codereview.chromium.org/11412214/


BUG=164023
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171159

[pedro (no code reviews), 2012-11-29 09:27:38]

Hey Evan. This is a follow up CL for the Apps Page. It implements the remaining
feature (showing 2 rows of Apps). Also, the styling of individual Apps has been
polished up.

[pedro (no code reviews), 2012-11-30 19:32:03]

Friendly ping.

[Evan Stade, 2012-11-30 20:57:18]

lgtm

[pedro (no code reviews), 2012-11-30 23:00:35]

Hey Holloway, I need you to review the chrome/browser/ui/search/search_ui.cc
file one more time! :)

[dhollowa, 2012-12-03 17:25:14]

lgtm

[commit-bot: I haz the power, 2012-12-03 20:26:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pedrosimonetti@chromium.org/11428075/5002

[commit-bot: I haz the power, 2012-12-03 20:26:52]

Failed to apply patch for chrome/browser/resources/ntp_search/apps_page.css:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/resources/ntp_search/apps_page.css
  Hunk #2 FAILED at 22.
  1 out of 2 hunks FAILED -- saving rejects to file
chrome/browser/resources/ntp_search/apps_page.css.rej

Patch:       chrome/browser/resources/ntp_search/apps_page.css
Index: chrome/browser/resources/ntp_search/apps_page.css
diff --git a/chrome/browser/resources/ntp_search/apps_page.css
b/chrome/browser/resources/ntp_search/apps_page.css
index
8a3a96fa8cb6e9858302248efde7f36e94a5b9d8..8bce3f54119f4725c71fdef64a3a3d8623d1bd6a
100644
--- a/chrome/browser/resources/ntp_search/apps_page.css
+++ b/chrome/browser/resources/ntp_search/apps_page.css
@@ -3,7 +3,7 @@
  * found in the LICENSE file. */
 
 .apps-page .tile-cell {
-  -webkit-margin-start: 12px;
+  -webkit-margin-start: 22px;
   margin-bottom: 12px;
 }
 
@@ -22,7 +22,7 @@
 .apps-page .app .title {
   color: #777;
   font-size: 0.9166em;
-  margin-top: 2px;
+  margin-top: 4px;
 }
 
 .app-contents {

[Dan Beam, 2012-12-03 20:52:35]

why does this CL have no BUG number?

[pedro (no code reviews), 2012-12-03 22:17:37]

Added BUG number.

[commit-bot: I haz the power, 2012-12-04 19:01:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pedrosimonetti@chromium.org/11428075/8001

[commit-bot: I haz the power, 2012-12-05 00:02:26]

Failed to apply patch for chrome/browser/ui/search/search_ui.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/ui/search/search_ui.cc
  Hunk #1 FAILED at 13.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/ui/search/search_ui.cc.rej

Patch:       chrome/browser/ui/search/search_ui.cc
Index: chrome/browser/ui/search/search_ui.cc
diff --git a/chrome/browser/ui/search/search_ui.cc
b/chrome/browser/ui/search/search_ui.cc
index
ba50a12382986bdacc93ec20b960f14a30a52b53..1a33d0e05f1429b2d76fc8d3aa02c0bd8ee247f5
100644
--- a/chrome/browser/ui/search/search_ui.cc
+++ b/chrome/browser/ui/search/search_ui.cc
@@ -13,7 +13,7 @@
 namespace chrome {
 namespace search {
 
-const int kMinContentHeightForBottomBookmarkBar = 558;
+const int kMinContentHeightForBottomBookmarkBar = 531;
 
 } //  namespace search
 } //  namespace chrome

[pedro (no code reviews), 2012-12-05 00:41:19]

On 2012/12/05 00:02:26, I haz the power (commit-bot) wrote:
> Failed to apply patch for chrome/browser/ui/search/search_ui.cc:
> While running patch -p1 --forward --force --no-backup-if-mismatch;
>   patching file chrome/browser/ui/search/search_ui.cc
>   Hunk #1 FAILED at 13.
>   1 out of 1 hunk FAILED -- saving rejects to file
> chrome/browser/ui/search/search_ui.cc.rej
> 
> Patch:       chrome/browser/ui/search/search_ui.cc
> Index: chrome/browser/ui/search/search_ui.cc
> diff --git a/chrome/browser/ui/search/search_ui.cc
> b/chrome/browser/ui/search/search_ui.cc
> index
>
ba50a12382986bdacc93ec20b960f14a30a52b53..1a33d0e05f1429b2d76fc8d3aa02c0bd8ee247f5
> 100644
> --- a/chrome/browser/ui/search/search_ui.cc
> +++ b/chrome/browser/ui/search/search_ui.cc
> @@ -13,7 +13,7 @@
>  namespace chrome {
>  namespace search {
>  
> -const int kMinContentHeightForBottomBookmarkBar = 558;
> +const int kMinContentHeightForBottomBookmarkBar = 531;
>  
>  } //  namespace search
>  } //  namespace chrome

The patch failed because search_ui.cc file has been deleted, and its constants
have been moved to search_ui.h. I've already spoken with Holloway about this
offline, and since this is a one-line change, it doesn't require another review.
I tested the new patch and it is working.

[commit-bot: I haz the power, 2012-12-05 00:43:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pedrosimonetti@chromium.org/11428075/1...

[commit-bot: I haz the power, 2012-12-05 04:26:42]

Change committed as 171159