Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 11428073: Wrote audio- and video-only WebRTC call tests. (Closed)

Created:
8 years ago by phoglund_chromium
Modified:
8 years ago
Reviewers:
dennis_jeffrey, jam
CC:
chromium-reviews, dennis_jeffrey, robertshield, anantha, kkania, dyu1
Visibility:
Public.

Description

Wrote audio- and video-only WebRTC call tests. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170930

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -17 lines) Patch
M chrome/browser/automation/testing_automation_provider.cc View 1 chunk +9 lines, -2 lines 1 comment Download
M chrome/test/functional/webrtc_call.py View 6 chunks +32 lines, -13 lines 0 comments Download
M chrome/test/functional/webrtc_test_base.py View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
phoglund_chromium
Adding new tests. https://chromiumcodereview.appspot.com/11428073/diff/1/chrome/browser/automation/testing_automation_provider.cc File chrome/browser/automation/testing_automation_provider.cc (right): https://chromiumcodereview.appspot.com/11428073/diff/1/chrome/browser/automation/testing_automation_provider.cc#newcode2261 chrome/browser/automation/testing_automation_provider.cc:2261: HasVideo() == true -> web page ...
8 years ago (2012-11-29 10:11:36 UTC) #1
dennis_jeffrey
LGTM You'll need an OWNERS review for the change to chrome/browser/automation.
8 years ago (2012-11-29 21:21:31 UTC) #2
phoglund_chromium
jam@: have a look at the automation controller changes. The purpose of them is to ...
8 years ago (2012-11-30 10:43:31 UTC) #3
jam
lgtm
8 years ago (2012-11-30 17:38:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phoglund@chromium.org/11428073/1
8 years ago (2012-12-03 14:17:46 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) ash_unittests
8 years ago (2012-12-03 15:34:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phoglund@chromium.org/11428073/1
8 years ago (2012-12-03 16:00:52 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) ash_unittests
8 years ago (2012-12-03 16:56:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phoglund@chromium.org/11428073/1
8 years ago (2012-12-03 18:11:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phoglund@chromium.org/11428073/1
8 years ago (2012-12-03 18:57:59 UTC) #10
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests
8 years ago (2012-12-04 00:24:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phoglund@chromium.org/11428073/1
8 years ago (2012-12-04 08:41:28 UTC) #12
commit-bot: I haz the power
8 years ago (2012-12-04 11:48:11 UTC) #13
Message was sent while issue was closed.
Change committed as 170930

Powered by Google App Engine
This is Rietveld 408576698