Some required fixes for HTMLViewer rotate

Some required fixes for HTMLViewer rotate

* View system calls onDetachedFromWindow after HTMLViewer already
calle destroy so need a check in onDetachedFromWindow.
* PageID in restored entries needs to be reset (0-indexed).
* Need to call NavigationController::LoadIfNecessary after calling
Restore to actually load the restored page.
* Need to call onTitleUpdated callback since title is restored and
the callback is optimized out inside chromium.

BUG=
TBR=joth@chromium.org
Android only change. Ran through android trybots.
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170484

[joth, 2012-11-29 05:56:14]

lgtm

https://codereview.chromium.org/11428070/diff/1005/android_webview/java/src/o...
File android_webview/java/src/org/chromium/android_webview/AwContents.java
(right):

https://codereview.chromium.org/11428070/diff/1005/android_webview/java/src/o...
android_webview/java/src/org/chromium/android_webview/AwContents.java:582:
onResume();
This would seem clearer as

if (!mIsPaused) mContentViewCore.onShow()

https://codereview.chromium.org/11428070/diff/1005/android_webview/native/sta...
File android_webview/native/state_serializer.cc (right):

https://codereview.chromium.org/11428070/diff/1005/android_webview/native/sta...
android_webview/native/state_serializer.cc:102:
restored_entries[i]->SetPageID(i);
should we be storing  GetPageID in saveState and restore it here? (if chrome 
already does it this way, then fair enough)

[boliu, 2012-11-29 06:14:02]

This is not ready to land yet since the test is not passing. May remove test out
of this depending on fix required.

https://codereview.chromium.org/11428070/diff/1005/android_webview/native/sta...
File android_webview/native/state_serializer.cc (right):

https://codereview.chromium.org/11428070/diff/1005/android_webview/native/sta...
android_webview/native/state_serializer.cc:102:
restored_entries[i]->SetPageID(i);
On 2012/11/29 05:56:14, joth wrote:
> should we be storing  GetPageID in saveState and restore it here? (if chrome 
> already does it this way, then fair enough)

PageID is incrementing counter in NavigationController for each new page
navigated in the controller. No need to save old values since it might have
gaps. This is what chrome does as well.

[boliu, 2012-11-30 17:20:51]

Patch Set 3 TBR=joth

[commit-bot: I haz the power, 2012-11-30 18:04:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/boliu@chromium.org/11428070/6001

[commit-bot: I haz the power, 2012-11-30 18:05:17]

Change committed as 170484