Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 11428056: Fix the crash when the SandboxedProcessService is destroyed through onDestroy. (Closed)

Created:
8 years ago by michaelbai
Modified:
8 years ago
Reviewers:
Yaron, Jay Civelli
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Fix the crash when the SandboxedProcessService is destroyed through onDestroy. Didn't call nativeShutdownSandboxMainThread on Java service thread. BUG=163017 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170204

Patch Set 1 : #

Patch Set 2 : Using MessageLoop::current() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -7 lines) Patch
M content/app/android/sandboxed_process_service.cc View 1 3 chunks +16 lines, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/app/SandboxedProcessService.java View 2 chunks +5 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
michaelbai
I were unable to reproduce the crash, but I think this fix is right, at ...
8 years ago (2012-11-28 21:40:40 UTC) #1
Yaron
8 years ago (2012-11-28 23:48:14 UTC) #2
Jay Civelli
lgtm
8 years ago (2012-11-29 00:31:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaelbai@chromium.org/11428056/4001
8 years ago (2012-11-29 04:40:54 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) content_unittests
8 years ago (2012-11-29 06:34:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaelbai@chromium.org/11428056/4001
8 years ago (2012-11-29 16:21:37 UTC) #6
commit-bot: I haz the power
8 years ago (2012-11-29 16:51:56 UTC) #7
Message was sent while issue was closed.
Change committed as 170204

Powered by Google App Engine
This is Rietveld 408576698