Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(778)

Unified Diff: android_webview/browser/net/input_stream_reader.h

Issue 11428052: [android_webview] Fix use after free in intercepted requests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/browser/net/input_stream_reader.h
diff --git a/android_webview/browser/net/input_stream_reader.h b/android_webview/browser/net/input_stream_reader.h
index 897040eb948e1f20115a5f0bcc7e5ec69e20831b..9e781adce83441bf8395413fc29c2c0f76612b28 100644
--- a/android_webview/browser/net/input_stream_reader.h
+++ b/android_webview/browser/net/input_stream_reader.h
@@ -17,11 +17,11 @@ namespace android_webview {
class InputStream;
// Class responsible for reading the InputStream.
-class InputStreamReader
- : public base::RefCountedThreadSafe<InputStreamReader> {
+class InputStreamReader {
public:
// The constructor is called on the IO thread, not on the worker thread.
InputStreamReader(android_webview::InputStream* stream);
+ virtual ~InputStreamReader();
// Perform a seek operation on the InputStream associated with this job.
// On successful completion the InputStream would have skipped reading the
@@ -41,12 +41,7 @@ class InputStreamReader
// will indicate the expected size of the content.
virtual int ReadRawData(net::IOBuffer* buffer, int buffer_size);
- protected:
- virtual ~InputStreamReader();
-
private:
- friend class base::RefCountedThreadSafe<InputStreamReader>;
-
// Verify the requested range against the stream size.
// net::OK is returned on success, the error code otherwise.
int VerifyRequestedRange(net::HttpByteRange* byte_range,

Powered by Google App Engine
This is Rietveld 408576698