Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11428049: Remove ibus dependency from IBusBus related stuff. (Closed)

Created:
8 years ago by Seigo Nonaka
Modified:
8 years ago
Reviewers:
satorux1
CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Remove ibus dependency from IBusBus related stuff. This CL depends on https://codereview.chromium.org/11280159/ BUG=158265 TEST=Manually done on lumpy Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170677

Patch Set 1 #

Patch Set 2 : Restore previous input method at the beggining of connection #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -15 lines) Patch
M chrome/browser/chromeos/input_method/ibus_controller_impl.cc View 1 5 chunks +14 lines, -15 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Seigo Nonaka
8 years ago (2012-11-28 13:34:05 UTC) #1
satorux1
LGTM
8 years ago (2012-11-28 23:43:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/11428049/3001
8 years ago (2012-12-01 12:30:40 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests
8 years ago (2012-12-01 16:24:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/11428049/3001
8 years ago (2012-12-01 17:46:15 UTC) #5
commit-bot: I haz the power
8 years ago (2012-12-01 23:09:44 UTC) #6
Message was sent while issue was closed. 
Change committed as 170677

Powered by Google App Engine
This is Rietveld 408576698