Issue 11428025: Include more information in --prof log.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11428025: Include more information in --prof log. (Closed)

Created:
8 years ago by Yang

Modified:
8 years ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Include more information in --prof log. Main changes: - include timestamps in profile ticks - include code kind in code create events - time execution in external code - changed plot-timer-events.js to show the code kind being executed R=jkummerow@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=13074

Patch Set 1 #

Total comments: 1

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+262 lines, -94 lines)			Patch
M	src/log.h	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	src/log.cc	View	9 chunks	+33 lines, -12 lines	0 comments	Download
M	src/vm-state-inl.h	View	2 chunks	+8 lines, -0 lines	0 comments	Download
M	tools/plot-timer-events	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/plot-timer-events.js	View	8 chunks	+210 lines, -77 lines	1 comment	Download
M	tools/tickprocessor.js	View	6 chunks	+6 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

8 years ago (2012-11-28 09:18:47 UTC) #2

LGTM

https://chromiumcodereview.appspot.com/11428025/diff/1/tools/plot-timer-event...
File tools/plot-timer-events.js (right):

https://chromiumcodereview.appspot.com/11428025/diff/1/tools/plot-timer-event...
tools/plot-timer-events.js:29: var kStackFrames = 16;
As discussed offline, a smaller number is probably enough here (4 maybe?).

Expand Messages | Collapse Messages