Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1183)

Issue 11421214: Fixed issue with miscalculated aria-posinset attribute's value. (Closed)

Created:
8 years ago by mtomasz
Modified:
8 years ago
CC:
chromium-reviews, arv (Not doing code reviews), dmazzoni
Visibility:
Public.

Description

Fixed issue with miscalculated aria-posinset attribute's value. This bug was caused by returning a string as an index from list_selection_model.js in an Event argument of a change event. In the list.js, such index stored as string was incremented, which caused concatenation instead of incrementation. This patch converts these values to number to avoid such problems. TEST=Enable ChromeVox, enter Files.app (CTRL-M), navigate among files. Correct item number should be spoken, eg. 2/x, 3/x. BUG=164061 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171056

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/shared/js/cr/ui/list_selection_model.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
mtomasz
8 years ago (2012-12-04 01:55:54 UTC) #1
mtomasz
@arv: PTAL.
8 years ago (2012-12-04 01:56:01 UTC) #2
mtomasz
8 years ago (2012-12-04 01:56:17 UTC) #3
arv (Not doing code reviews)
LGTM https://codereview.chromium.org/11421214/diff/1/chrome/browser/resources/shared/js/cr/ui/list_selection_model.js File chrome/browser/resources/shared/js/cr/ui/list_selection_model.js (right): https://codereview.chromium.org/11421214/diff/1/chrome/browser/resources/shared/js/cr/ui/list_selection_model.js#newcode230 chrome/browser/resources/shared/js/cr/ui/list_selection_model.js:230: index: index, or just do the conversion here ...
8 years ago (2012-12-04 15:33:36 UTC) #4
mtomasz
https://codereview.chromium.org/11421214/diff/1/chrome/browser/resources/shared/js/cr/ui/list_selection_model.js File chrome/browser/resources/shared/js/cr/ui/list_selection_model.js (right): https://codereview.chromium.org/11421214/diff/1/chrome/browser/resources/shared/js/cr/ui/list_selection_model.js#newcode230 chrome/browser/resources/shared/js/cr/ui/list_selection_model.js:230: index: index, On 2012/12/04 15:33:36, arv wrote: > or ...
8 years ago (2012-12-04 18:53:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/11421214/1002
8 years ago (2012-12-04 18:53:22 UTC) #6
commit-bot: I haz the power
8 years ago (2012-12-04 21:51:04 UTC) #7
Message was sent while issue was closed.
Change committed as 171056

Powered by Google App Engine
This is Rietveld 408576698