Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4539)

Unified Diff: chrome/browser/ui/webui/extensions/extension_activity_ui.cc

Issue 11421192: Save extension activity log to a file. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: something about lkgr Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/extensions/extension_activity_ui.h ('k') | chrome/chrome_browser_extensions.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/extensions/extension_activity_ui.cc
===================================================================
--- chrome/browser/ui/webui/extensions/extension_activity_ui.cc (revision 177317)
+++ chrome/browser/ui/webui/extensions/extension_activity_ui.cc (working copy)
@@ -41,11 +41,11 @@
// Resources.
source->add_resource_path("extension_activity.js", IDR_EXTENSION_ACTIVITY_JS);
source->set_default_resource(IDR_EXTENSION_ACTIVITY_HTML);
+ profile_ = Profile::FromWebUI(web_ui);
+ ChromeURLDataManager::AddDataSourceImpl(profile_, source);
+ ChromeURLDataManager::AddDataSource(
+ profile_, new SharedResourcesDataSource());
- Profile* profile = Profile::FromWebUI(web_ui);
- ChromeURLDataManager::AddDataSourceImpl(profile, source);
- ChromeURLDataManager::AddDataSource(profile, new SharedResourcesDataSource());
-
// Callback handlers.
web_ui->RegisterMessageCallback("requestExtensionData",
base::Bind(&ExtensionActivityUI::HandleRequestExtensionData,
@@ -54,7 +54,8 @@
ExtensionActivityUI::~ExtensionActivityUI() {
if (extension_)
- extensions::ActivityLog::GetInstance()->RemoveObserver(extension_, this);
+ extensions::ActivityLog::GetInstance(profile_)->RemoveObserver(
+ extension_, this);
}
void ExtensionActivityUI::HandleRequestExtensionData(
@@ -65,8 +66,7 @@
if (!args->GetString(0, &extension_id))
return;
- ExtensionService* extension_service = Profile::FromWebUI(web_ui())->
- GetExtensionService();
+ ExtensionService* extension_service = profile_->GetExtensionService();
extension_ = extension_service->GetExtensionById(extension_id, false);
if (!extension_)
return;
@@ -90,15 +90,15 @@
web_ui()->CallJavascriptFunction("extension_activity.handleExtensionData",
result);
- extensions::ActivityLog::GetInstance()->AddObserver(extension_, this);
+ extensions::ActivityLog::GetInstance(profile_)->AddObserver(extension_, this);
}
void ExtensionActivityUI::OnExtensionActivity(
const extensions::Extension* extension,
extensions::ActivityLog::Activity activity,
- const std::vector<std::string>& messages) {
+ const std::string& message) {
scoped_ptr<ListValue> messages_list(new ListValue());
- messages_list->AppendStrings(messages);
+ messages_list->AppendString(message);
DictionaryValue result;
result.SetInteger("activity", activity);
« no previous file with comments | « chrome/browser/ui/webui/extensions/extension_activity_ui.h ('k') | chrome/chrome_browser_extensions.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698