Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 11421191: Notify the ThemeService on extension install and not extension load (Closed)

Created:
8 years ago by akalin
Modified:
8 years ago
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org, simonjam
Visibility:
Public.

Description

Notify the ThemeService on extension install and not extension load This is a speculative fix for the startup regression introduced by 169875. Also fix a bug in GtkThemeService where use_gtk_ wasn't being set to false if a custom theme was installed before the ThemeService was created. BUG=163706 TBR=estade@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170640

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M chrome/browser/extensions/extension_service.cc View 2 chunks +8 lines, -5 lines 2 comments Download
M chrome/browser/ui/gtk/gtk_theme_service.cc View 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
akalin
+asargent for extensions stuff +estade for themes stuff
8 years ago (2012-12-01 00:29:05 UTC) #1
akalin
+simonjam fyi
8 years ago (2012-12-01 00:29:41 UTC) #2
asargent_no_longer_on_chrome
LGTM https://codereview.chromium.org/11421191/diff/1/chrome/browser/extensions/extension_service.cc File chrome/browser/extensions/extension_service.cc (right): https://codereview.chromium.org/11421191/diff/1/chrome/browser/extensions/extension_service.cc#newcode2119 chrome/browser/extensions/extension_service.cc:2119: #endif Perhaps this should go inside DoPostLoadTasks ?
8 years ago (2012-12-01 00:54:56 UTC) #3
akalin
I'll TBR estade so I can land this now and watch to see if it ...
8 years ago (2012-12-01 01:07:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akalin@chromium.org/11421191/1
8 years ago (2012-12-01 01:07:14 UTC) #5
commit-bot: I haz the power
Presubmit check for 11421191-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years ago (2012-12-01 01:07:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akalin@chromium.org/11421191/1
8 years ago (2012-12-01 01:11:37 UTC) #7
commit-bot: I haz the power
8 years ago (2012-12-01 03:08:22 UTC) #8
Message was sent while issue was closed.
Change committed as 170640

Powered by Google App Engine
This is Rietveld 408576698