Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1099)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11421180: Fix uber tray crash on stumpy which has no battery (Closed)

Created:
8 years ago by oshima
Modified:
8 years ago
Reviewers:
stevenjb, jennyz
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Fix uber tray crash on stumpy which has no battery BUG=163531 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170600

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M ash/system/settings/tray_settings.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
oshima
this fixes crash only. You probably want to do better for accessibility on stumpy though.
8 years ago (2012-11-30 20:23:04 UTC) #1
oshima
jenny is away from desk. steven, can you review?
8 years ago (2012-11-30 20:24:12 UTC) #2
stevenjb
lgtm https://codereview.chromium.org/11421180/diff/1/ash/system/settings/tray_settings.cc File ash/system/settings/tray_settings.cc (right): https://codereview.chromium.org/11421180/diff/1/ash/system/settings/tray_settings.cc#newcode72 ash/system/settings/tray_settings.cc:72: if (power_status_view_) { nit: if (!power_status_view_) return;?
8 years ago (2012-11-30 20:36:44 UTC) #3
jennyz
lgtm
8 years ago (2012-11-30 21:16:04 UTC) #4
oshima
https://codereview.chromium.org/11421180/diff/1/ash/system/settings/tray_settings.cc File ash/system/settings/tray_settings.cc (right): https://codereview.chromium.org/11421180/diff/1/ash/system/settings/tray_settings.cc#newcode72 ash/system/settings/tray_settings.cc:72: if (power_status_view_) { On 2012/11/30 20:36:44, stevenjb (chromium) wrote: ...
8 years ago (2012-11-30 21:23:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/11421180/5001
8 years ago (2012-11-30 21:23:39 UTC) #6
commit-bot: I haz the power
Retried try job too often on ios_rel_device for step(s) compile
8 years ago (2012-11-30 21:30:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/11421180/5001
8 years ago (2012-11-30 21:44:23 UTC) #8
commit-bot: I haz the power
Retried try job too often on ios_rel_device for step(s) compile
8 years ago (2012-11-30 21:51:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/11421180/5001
8 years ago (2012-11-30 22:12:04 UTC) #10
commit-bot: I haz the power
8 years ago (2012-11-30 23:49:01 UTC) #11
Message was sent while issue was closed. 
Change committed as 170600

Powered by Google App Engine
This is Rietveld 408576698