Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 11421179: Experimental: Fix HasWrongProcessForURL in --site-per-process mode. (Closed)

Created:
8 years ago by Charlie Reis
Modified:
8 years ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, creis+watch_chromium.org, ajwong+watch_chromium.org
Visibility:
Public.

Description

Experimental: Fix HasWrongProcessForURL in --site-per-process mode. The experimental --site-per-process and --enable-strict-site-isolation modes disable reuse of renderer processes to improve security. The previous approach of making IsSuitableHost return false was breaking HasWrongProcessForURL, so we now return false in ShouldTryToReuseExistingProcessHost instead. BUG=160671 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170821

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -13 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M content/browser/site_instance_impl_unittest.cc View 1 chunk +33 lines, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Charlie Reis
Robert, I think this should fix the issues you were seeing. Does it look right ...
8 years ago (2012-11-30 19:31:30 UTC) #1
irobert
On 2012/11/30 19:31:30, creis wrote: > Robert, I think this should fix the issues you ...
8 years ago (2012-11-30 20:29:44 UTC) #2
Charlie Reis
Darin, can you review? Our previous experimental approach had problems that this resolves. Thanks! Charlie
8 years ago (2012-11-30 20:33:05 UTC) #3
darin (slow to review)
LGTM
8 years ago (2012-12-03 17:59:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/creis@chromium.org/11421179/1
8 years ago (2012-12-03 18:57:05 UTC) #5
commit-bot: I haz the power
8 years ago (2012-12-03 22:09:04 UTC) #6
Message was sent while issue was closed.
Change committed as 170821

Powered by Google App Engine
This is Rietveld 408576698