Issue 11421172: jingle: Update the calls from RunAllPending() to RunUntilIdle().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11421172: jingle: Update the calls from RunAllPending() to RunUntilIdle(). (Closed)

Created:
8 years ago by tfarina

Modified:
8 years ago

Reviewers:
Sergey Ulanov, awong

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

jingle: Update the calls from RunAllPending() to RunUntilIdle(). RunAllPending() is deprecated and we should switch to RunUntilIdle(). BUG=131220 TBR=ajwong@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170464

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+60 lines, -60 lines)			Patch
M	jingle/glue/chrome_async_socket_unittest.cc	View	23 chunks	+37 lines, -37 lines	0 comments	Download
M	jingle/glue/proxy_resolving_client_socket_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	jingle/glue/task_pump_unittest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	jingle/glue/thread_wrapper_unittest.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	jingle/notifier/base/xmpp_connection_unittest.cc	View	5 chunks	+5 lines, -5 lines	0 comments	Download
M	jingle/notifier/communicator/single_login_attempt_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	jingle/notifier/listener/non_blocking_push_client_unittest.cc	View	7 chunks	+10 lines, -10 lines	0 comments	Download
M	jingle/notifier/listener/xmpp_push_client_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/11421172/1

8 years ago (2012-11-30 12:33:56 UTC) #2

Message was sent while issue was closed.

LGTM, but adding sergeyu@ as FYI