Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 11421169: [Spellcheck] Explose the flag for autocorrect. (Closed)

Created:
8 years ago by rpetterson
Modified:
8 years ago
Reviewers:
groby-ooo-7-16, sky
CC:
chromium-reviews
Visibility:
Public.

Description

[Spellcheck] Explose the flag for autocorrect. To allow for easier testing. BUG=7624 TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170410

Patch Set 1 #

Total comments: 2

Patch Set 2 : fixing copy/paste error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
rpetterson
groby - general spelling goodness sky - TBR for owners approval for about_flags
8 years ago (2012-11-30 02:17:35 UTC) #1
groby-ooo-7-16
https://codereview.chromium.org/11421169/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/11421169/diff/1/chrome/app/generated_resources.grd#newcode6857 chrome/app/generated_resources.grd:6857: + Force Synchronous Spellchecking Shouldn't this be "enable autocorrect"?
8 years ago (2012-11-30 02:19:22 UTC) #2
rpetterson
https://codereview.chromium.org/11421169/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/11421169/diff/1/chrome/app/generated_resources.grd#newcode6857 chrome/app/generated_resources.grd:6857: + Force Synchronous Spellchecking On 2012/11/30 02:19:22, groby wrote: ...
8 years ago (2012-11-30 02:23:57 UTC) #3
groby-ooo-7-16
lgtm
8 years ago (2012-11-30 02:24:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlp@chromium.org/11421169/4001
8 years ago (2012-11-30 02:30:48 UTC) #5
commit-bot: I haz the power
8 years ago (2012-11-30 05:51:34 UTC) #6
Message was sent while issue was closed.
Change committed as 170410

Powered by Google App Engine
This is Rietveld 408576698