[NaCl SDK] update_nacl_manifest: Allow manual updating of a version.

[NaCl SDK] update_nacl_manifest: Allow manual updating of a version.

* New argument --bundle-version, can be passed multiple times. The updater will
use the version passed in.
* The updater won't upload a manifest if it hasn't changed.
* The updater won't rollback a bundle (i.e. if the automatically determined
  revision is older, it will keep the current bundle).
* Switch --dryrun to use difflib instead of system diff.
* Add equality testing for manifest_util.SDKManifest. It already existed for
  Bundles.

BUG=none
R=sbc@chromium.org
TBR=noelallen@chromium.org
NOTRY=true


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170500

[Sam Clegg, 2012-11-29 19:39:10]

lgtm

https://codereview.chromium.org/11421138/diff/2001/native_client_sdk/src/buil...
File native_client_sdk/src/build_tools/manifest_util.py (right):

https://codereview.chromium.org/11421138/diff/2001/native_client_sdk/src/buil...
native_client_sdk/src/build_tools/manifest_util.py:554: other_bundle_names =
set([b.name for b in other.GetBundles()])

You can drop the square brackets in these kind of calls.
(like when you call any or all).

https://codereview.chromium.org/11421138/diff/2001/native_client_sdk/src/buil...
File native_client_sdk/src/build_tools/tests/test_update_nacl_manifest.py
(right):

https://codereview.chromium.org/11421138/diff/2001/native_client_sdk/src/buil...
native_client_sdk/src/build_tools/tests/test_update_nacl_manifest.py:549:
self.assertEqual(False, self.delegate.called_gsutil_cp)
assertFalse() here and below?

[binji, 2012-11-30 18:55:00]

https://codereview.chromium.org/11421138/diff/2001/native_client_sdk/src/buil...
File native_client_sdk/src/build_tools/manifest_util.py (right):

https://codereview.chromium.org/11421138/diff/2001/native_client_sdk/src/buil...
native_client_sdk/src/build_tools/manifest_util.py:554: other_bundle_names =
set([b.name for b in other.GetBundles()])
On 2012/11/29 19:39:10, Sam Clegg wrote:
> 
> You can drop the square brackets in these kind of calls.
> (like when you call any or all).

Done.

https://codereview.chromium.org/11421138/diff/2001/native_client_sdk/src/buil...
File native_client_sdk/src/build_tools/tests/test_update_nacl_manifest.py
(right):

https://codereview.chromium.org/11421138/diff/2001/native_client_sdk/src/buil...
native_client_sdk/src/build_tools/tests/test_update_nacl_manifest.py:549:
self.assertEqual(False, self.delegate.called_gsutil_cp)
On 2012/11/29 19:39:10, Sam Clegg wrote:
> assertFalse() here and below?

Done.

[commit-bot: I haz the power, 2012-11-30 18:55:14]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[commit-bot: I haz the power, 2012-11-30 18:59:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/binji@chromium.org/11421138/6002

[commit-bot: I haz the power, 2012-11-30 19:00:26]

Change committed as 170500