Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Side by Side Diff: ash/wm/workspace/workspace.cc

Issue 11421006: Desktop aura: Break aura::Window::SetParent in two. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix ash_unittests Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/wm/workspace/workspace.h" 5 #include "ash/wm/workspace/workspace.h"
6 6
7 #include "ash/shell_window_ids.h" 7 #include "ash/shell_window_ids.h"
8 #include "ash/wm/property_util.h" 8 #include "ash/wm/property_util.h"
9 #include "ash/wm/window_animations.h" 9 #include "ash/wm/window_animations.h"
10 #include "ash/wm/window_properties.h" 10 #include "ash/wm/window_properties.h"
(...skipping 16 matching lines...) Expand all
27 workspace_layout_manager_(NULL) { 27 workspace_layout_manager_(NULL) {
28 window_->SetProperty(internal::kChildWindowVisibilityChangesAnimatedKey, 28 window_->SetProperty(internal::kChildWindowVisibilityChangesAnimatedKey,
29 true); 29 true);
30 SetWindowVisibilityAnimationTransition(window_, ANIMATE_NONE); 30 SetWindowVisibilityAnimationTransition(window_, ANIMATE_NONE);
31 window_->set_id(kShellWindowId_WorkspaceContainer); 31 window_->set_id(kShellWindowId_WorkspaceContainer);
32 window_->SetName("WorkspaceContainer"); 32 window_->SetName("WorkspaceContainer");
33 window_->Init(ui::LAYER_NOT_DRAWN); 33 window_->Init(ui::LAYER_NOT_DRAWN);
34 // Do this so when animating out windows don't extend beyond the bounds. 34 // Do this so when animating out windows don't extend beyond the bounds.
35 window_->layer()->SetMasksToBounds(true); 35 window_->layer()->SetMasksToBounds(true);
36 window_->Hide(); 36 window_->Hide();
37 window_->SetParent(parent); 37 parent->AddChild(window_);
38 window_->SetProperty(internal::kUsesScreenCoordinatesKey, true); 38 window_->SetProperty(internal::kUsesScreenCoordinatesKey, true);
39 39
40 // The layout-manager cannot be created in the initializer list since it 40 // The layout-manager cannot be created in the initializer list since it
41 // depends on the window to have been initialized. 41 // depends on the window to have been initialized.
42 workspace_layout_manager_ = new WorkspaceLayoutManager(this); 42 workspace_layout_manager_ = new WorkspaceLayoutManager(this);
43 window_->SetLayoutManager(workspace_layout_manager_); 43 window_->SetLayoutManager(workspace_layout_manager_);
44 } 44 }
45 45
46 Workspace::~Workspace() { 46 Workspace::~Workspace() {
47 // ReleaseWindow() should have been invoked before we're deleted. 47 // ReleaseWindow() should have been invoked before we're deleted.
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 WorkspaceManager::WillRestoreMaximized(child))) { 86 WorkspaceManager::WillRestoreMaximized(child))) {
87 if (++count == 2) 87 if (++count == 2)
88 return count; 88 return count;
89 } 89 }
90 } 90 }
91 return count; 91 return count;
92 } 92 }
93 93
94 } // namespace internal 94 } // namespace internal
95 } // namespace ash 95 } // namespace ash
OLDNEW
« no previous file with comments | « ash/wm/workspace/multi_window_resize_controller_unittest.cc ('k') | ash/wm/workspace/workspace_event_handler_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698