Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 11420092: Android: fixes after r168792. (Closed)

Created:
8 years, 1 month ago by bulach
Modified:
8 years, 1 month ago
Reviewers:
John Knottenbelt
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Android: fixes after r168792. Removes obsolete reference since the package has moved. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=168819

Patch Set 1 #

Patch Set 2 : Findbugs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M build/android/findbugs_filter/findbugs_known_bugs.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/content_components_navigation_interception.gypi View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
bulach
8 years, 1 month ago (2012-11-20 13:40:07 UTC) #1
John Knottenbelt
LGTM. Thanks Marcus!
8 years, 1 month ago (2012-11-20 13:52:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/11420092/1
8 years, 1 month ago (2012-11-20 13:54:18 UTC) #3
commit-bot: I haz the power
Retried try job too often for step(s) build
8 years, 1 month ago (2012-11-20 14:45:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/11420092/3003
8 years, 1 month ago (2012-11-20 15:21:27 UTC) #5
Yaron
On 2012/11/20 15:21:27, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
8 years, 1 month ago (2012-11-20 17:02:59 UTC) #6
John Knottenbelt
That is a mystery indeed, android_webview_java depends on the navigation_interception_java, so it should have broken. ...
8 years, 1 month ago (2012-11-20 17:10:51 UTC) #7
commit-bot: I haz the power
Change committed as 168819
8 years, 1 month ago (2012-11-20 17:18:06 UTC) #8
bulach
hehe, too many "builds" :) it broke the canaries and myself (I'm using ToT), and ...
8 years, 1 month ago (2012-11-20 17:18:36 UTC) #9
Yaron
8 years, 1 month ago (2012-11-20 17:19:15 UTC) #10
On 2012/11/20 17:18:36, bulach wrote:
> hehe, too many "builds" :)
> it broke the canaries and myself (I'm using ToT), and that probably explains
the
> few other people?
> 
> I think the gardened version didn't roll past it, so it may not break those...
> upstream probably didn't depend on this target, so nothing was broken there..
> 
> no idea how plausible this explanation is though :)

No, Tommy had issues with upstream client.

Powered by Google App Engine
This is Rietveld 408576698