Chromium Code Reviews
Help | Chromium Project | Sign in
(2)

Issue 11420036: Remove eager sweeping for lazy swept spaces. Try to find in SlowAllocateRaw a bounded number of tim… (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 7 months ago by Hannes Payer
Modified:
2 years, 7 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Remove eager sweeping for lazy swept spaces. Try to find in SlowAllocateRaw a bounded number of times a big enough memory slot. BUG=v8:2194 Committed: https://code.google.com/p/v8/source/detail?r=13058

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -14 lines) Patch
M src/mark-compact.cc View 2 chunks +2 lines, -10 lines 0 comments Download
M src/spaces.cc View 1 1 chunk +7 lines, -4 lines 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 4 (0 generated)
Hannes Payer
2 years, 7 months ago (2012-11-16 14:14:49 UTC) #1
Michael Starzinger
This is looking good. I will compile it into Chromium to smoke-test it. https://codereview.chromium.org/11420036/diff/1/src/spaces.cc File ...
2 years, 7 months ago (2012-11-26 13:35:44 UTC) #2
Hannes Payer
https://codereview.chromium.org/11420036/diff/1/src/spaces.cc File src/spaces.cc (right): https://codereview.chromium.org/11420036/diff/1/src/spaces.cc#newcode2397 src/spaces.cc:2397: int i = 0; On 2012/11/26 13:35:44, Michael Starzinger ...
2 years, 7 months ago (2012-11-26 14:06:40 UTC) #3
Michael Starzinger
2 years, 7 months ago (2012-11-26 14:31:08 UTC) #4
LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1f9106d