Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1026)

Issue 11420021: Handle NinePatchLayer Resource Rebuilding. (Closed)

Created:
8 years, 1 month ago by David Trainor- moved to gerrit
Modified:
8 years, 1 month ago
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

Handle NinePatchLayer Resource Rebuilding. When we minimize the application our PrioritizedResourceManager dies. This clears the PrioritizedTexture state and decouples the texture from the manager. When we bring our application back to the foreground a new PrioritizedResourceManager is created, but we still hold onto our old PrioritizedResource. Trying to reupload a bitmap on this resource fails due to a variety of DCHECK/CHECKs at this point. Now if the PrioritizedResource has no PrioritizedResourceManager we rebuild the resource. BUG=http://crbug.com/161278 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=168122

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -8 lines) Patch
M cc/nine_patch_layer.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/nine_patch_layer.cc View 2 chunks +18 lines, -8 lines 0 comments Download
M cc/nine_patch_layer_unittest.cc View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
David Trainor- moved to gerrit
PTAL. We were getting consistent crashes on bringing Chrome for Android back to the foreground, ...
8 years, 1 month ago (2012-11-15 22:22:05 UTC) #1
aelias_OOO_until_Jul13
lgtm
8 years, 1 month ago (2012-11-15 23:30:17 UTC) #2
David Trainor- moved to gerrit
Hey enne would you mind taking a quick look at this? Sorry for pinging both ...
8 years, 1 month ago (2012-11-15 23:35:42 UTC) #3
jamesr
lgtm sorry for the delay - I thought aelias@ was OWNERS here already, but looks ...
8 years, 1 month ago (2012-11-15 23:37:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtrainor@chromium.org/11420021/1
8 years, 1 month ago (2012-11-15 23:44:08 UTC) #5
enne (OOO)
This is exactly the kind of roll-your-own-resource-management bug that I was hoping a DecorationManager would ...
8 years, 1 month ago (2012-11-15 23:49:35 UTC) #6
aelias_OOO_until_Jul13
On 2012/11/15 23:49:35, enne wrote: > This is exactly the kind of roll-your-own-resource-management bug that ...
8 years, 1 month ago (2012-11-15 23:53:35 UTC) #7
commit-bot: I haz the power
8 years, 1 month ago (2012-11-16 03:15:11 UTC) #8
Change committed as 168122

Powered by Google App Engine
This is Rietveld 408576698