sdk/lib/html/scripts/generator.py - Issue 11419300: Dartifying dart:html type names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/html/scripts/generator.py

Issue 11419300: Dartifying dart:html type names. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Incorporating review feedback. Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/html/scripts/generator.py

diff --git a/sdk/lib/html/scripts/generator.py b/sdk/lib/html/scripts/generator.py

index 1ba1bcd576fee9b3c010633cb448b1bcde7989b2..3d34d019387ad574e67c23e8891446f968e715c3 100644

--- a/sdk/lib/html/scripts/generator.py

+++ b/sdk/lib/html/scripts/generator.py

@@ -631,20 +631,20 @@ dart2js_annotations = {

# IDBRequest.

'IDBRequest.source': "@Creates('Null')",

- 'IDBFactory.open': "@Creates('IDBDatabase')",

+ 'IDBFactory.open': "@Creates('Database')",

'IDBObjectStore.put': "@_annotation_Creates_IDBKey",

'IDBObjectStore.add': "@_annotation_Creates_IDBKey",

'IDBObjectStore.get': "@annotation_Creates_SerializedScriptValue",

- 'IDBObjectStore.openCursor': "@Creates('IDBCursor')",

+ 'IDBObjectStore.openCursor': "@Creates('Cursor')",

'IDBIndex.get': "@annotation_Creates_SerializedScriptValue",

'IDBIndex.getKey':

"@annotation_Creates_SerializedScriptValue "

# The source is the object store behind the index.

- "@Creates('IDBObjectStore')",

- 'IDBIndex.openCursor': "@Creates('IDBCursor')",

- 'IDBIndex.openKeyCursor': "@Creates('IDBCursor')",

+ "@Creates('ObjectStore')",

+ 'IDBIndex.openCursor': "@Creates('Cursor')",

+ 'IDBIndex.openKeyCursor': "@Creates('Cursor')",

'IDBCursorWithValue.value':

'@annotation_Creates_SerializedScriptValue '

@@ -652,10 +652,10 @@ dart2js_annotations = {

'IDBCursor.key': "@_annotation_Creates_IDBKey @_annotation_Returns_IDBKey",

- '+IDBRequest': "@Returns('IDBRequest') @Creates('IDBRequest')",

+ '+IDBRequest': "@Returns('Request') @Creates('Request')",

- '+IDBOpenDBRequest': "@Returns('IDBRequest') @Creates('IDBRequest')",

- '+IDBVersionChangeRequest': "@Returns('IDBRequest') @Creates('IDBRequest')",

+ '+IDBOpenDBRequest': "@Returns('Request') @Creates('Request')",

+ '+IDBVersionChangeRequest': "@Returns('Request') @Creates('Request')",

'MessageEvent.ports': "@Creates('=List')",