Issue 11419299: Re-enable dynamic NEON support in Skia.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11419299: Re-enable dynamic NEON support in Skia. (Closed)

Created:
8 years ago by digit1

Modified:
8 years ago

Reviewers:
Tom Hudson, joth, djsollen1, Torne, reed2

CC:
chromium-reviews, ilevy+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, peter+watch_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Re-enable dynamic NEON support in Skia. The Skia build depends on arm_neon_optional=1 being defined in GYP_DEFINES to enable dynamic NEON support. It looks like this option was lost in translation during the upstreaming of build/android/. Note that this won't fix crbug.com/161834, i.e. on JB and higher, the sandboxing currently prevents the CPU feature detection from working, but it's a first step in the right direction (it fixes the code for ICS devices though). BUG=164002 R=joth@chromium.org,torne@chromium.org,djsollen@chromium.org,tomhudson@chromium.org,reed@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171001

Patch Set 1 #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	build/android/envsetup_functions.sh	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/digit@chromium.org/11419299/1

8 years ago (2012-12-04 15:03:34 UTC) #5

Message was sent while issue was closed.

Change committed as 171001

Expand Messages | Collapse Messages