Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 11419277: Fix showing constrained window for uninitialized tabs (Closed)

Created:
8 years ago by sail
Modified:
8 years ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, sail+watch_chromium.org
Visibility:
Public.

Description

Fix showing constrained window for uninitialized tabs If a tab is added without being shown then the associated tab view for the web content will not be created yet. When a constrained window is added to that tab the window never gets shown. To fix this I've changed ConstrainedWindowMac2 to reshow the window once the web contents becomes visible. Note, this change was reverted because ConstrainedWindowMacTest.ShowInUninitializedTab was failing. The code that was causing the failure was deleted in r171328 so it's safe to check this in again. (Old commit revision r170795). BUG=163778 TEST=Reproduced bug 163778 and verified that my patch fixes it. Verified that ConstrainedWindowMacTest.ShowInUninitializedTab fails without my patch and passes with it. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171371

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -6 lines) Patch
M chrome/browser/ui/cocoa/constrained_window/constrained_window_mac2.h View 4 chunks +15 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_mac2.mm View 5 chunks +31 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_mac_browsertest.mm View 3 chunks +31 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
sail
8 years ago (2012-12-02 02:10:59 UTC) #1
Robert Sesek
LGTM
8 years ago (2012-12-03 16:17:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/11419277/1
8 years ago (2012-12-03 16:24:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/11419277/1
8 years ago (2012-12-03 18:56:31 UTC) #4
commit-bot: I haz the power
Change committed as 170795
8 years ago (2012-12-03 19:55:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/11419277/1
8 years ago (2012-12-06 00:21:17 UTC) #6
commit-bot: I haz the power
Presubmit check for 11419277-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years ago (2012-12-06 00:21:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/11419277/1
8 years ago (2012-12-06 00:33:13 UTC) #8
commit-bot: I haz the power
8 years ago (2012-12-06 00:57:37 UTC) #9
Message was sent while issue was closed.
Change committed as 171371

Powered by Google App Engine
This is Rietveld 408576698