Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 11419276: Remove tabstrip wrappers in browser_tabstrip. (Closed)

Created:
8 years ago by Avi (use Gerrit)
Modified:
8 years ago
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, groby+watch_chromium.org, estade+watch_chromium.org, marja+watch_chromium.org, dhollowa+watch_chromium.org, kkania, sail+watch_chromium.org, Aaron Boodman, scheib+watch_chromium.org, robertshield, rdsmith+dwatch_chromium.org, chromium-apps-reviews_chromium.org, gbillock+watch_chromium.org, darin-cc_chromium.org, smckay+watch_chromium.org, rouslan+watch_chromium.org, tfarina, pedrosimonetti+watch_chromium.org
Visibility:
Public.

Description

Remove tabstrip wrappers in browser_tabstrip. BUG=none TEST=no functional change Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170783

Patch Set 1 #

Patch Set 2 : gtk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+290 lines, -225 lines) Patch
M chrome/browser/automation/testing_automation_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/browser_commands_unittest.cc View 7 chunks +31 lines, -28 lines 0 comments Download
M chrome/browser/download/download_browsertest.cc View 24 chunks +26 lines, -25 lines 0 comments Download
M chrome/browser/extensions/api/extension_action/browser_action_apitest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/notifications/notification_browsertest.cc View 16 chunks +20 lines, -18 lines 0 comments Download
M chrome/browser/renderer_host/web_cache_manager_browsertest.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc View 21 chunks +34 lines, -22 lines 0 comments Download
M chrome/browser/sessions/session_restore.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_command_controller_browsertest.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser_commands.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_focus_uitest.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/browser_navigator.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_tabstrip.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_tabstrip.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/applescript/window_applescript.mm View 4 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/ui/find_bar/find_bar_host_browsertest.cc View 40 chunks +81 lines, -43 lines 0 comments Download
M chrome/browser/ui/fullscreen/fullscreen_controller_browsertest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk_interactive_uitest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/intents/web_intent_picker_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/omnibox_view_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/search/search_delegate_unittest.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/find_bar_host_interactive_uitest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/bookmarks_ui_browsertest.cc View 4 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/ui/webui/feedback_ui.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_ui_browsertest.cc View 4 chunks +14 lines, -8 lines 0 comments Download
M chrome/test/ppapi/ppapi_browsertest.cc View 4 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Avi (use Gerrit)
8 years ago (2012-12-01 23:31:32 UTC) #1
Ben Goodger (Google)
lgtm
8 years ago (2012-12-02 01:21:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/11419276/29
8 years ago (2012-12-03 14:47:43 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) ash_unittests
8 years ago (2012-12-03 15:48:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/11419276/29
8 years ago (2012-12-03 17:42:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/11419276/29
8 years ago (2012-12-03 18:55:58 UTC) #6
commit-bot: I haz the power
8 years ago (2012-12-03 19:15:46 UTC) #7
Message was sent while issue was closed.
Change committed as 170783

Powered by Google App Engine
This is Rietveld 408576698