Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 11419269: cc: Give ownership of render passes to the renderer when drawing a frame. (Closed)

Created:
8 years ago by danakj
Modified:
8 years ago
Reviewers:
piman, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org, backer
Visibility:
Public.

Description

cc: Give ownership of render passes to the renderer when drawing a frame. Instead of giving const pointers to the renderer, we should provide it with non-const pointers, and expect it to consume the render passes that we provide it. In ubercomp, the delegating renderer will pass ownership of the passes to the CompositorFrame. Covered by existing tests, no change in behaviour. BUG=152337 R=enne,piman NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170877

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -43 lines) Patch
M cc/delegated_renderer_layer_impl_unittest.cc View 13 chunks +32 lines, -22 lines 0 comments Download
M cc/direct_renderer.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/direct_renderer.cc View 2 chunks +4 lines, -1 line 0 comments Download
M cc/gl_renderer_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/layer_tree_host_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/layer_tree_host_impl.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M cc/layer_tree_host_impl_unittest.cc View 2 chunks +6 lines, -8 lines 0 comments Download
M cc/renderer.h View 1 chunk +3 lines, -1 line 0 comments Download
M cc/test/layer_tree_test_common.h View 1 chunk +1 line, -1 line 0 comments Download
cc/test/layer_tree_test_common.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
danakj
8 years ago (2012-12-01 01:14:07 UTC) #1
enne (OOO)
lgtm
8 years ago (2012-12-03 21:02:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/11419269/2001
8 years ago (2012-12-03 21:11:07 UTC) #3
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests
8 years ago (2012-12-04 03:22:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/11419269/2001
8 years ago (2012-12-04 03:25:05 UTC) #5
commit-bot: I haz the power
8 years ago (2012-12-04 03:56:09 UTC) #6
Message was sent while issue was closed.
Change committed as 170877

Powered by Google App Engine
This is Rietveld 408576698