Remove ProcessSingleton::FoundOtherProcessWindow() as it is no longer required.

Remove ProcessSingleton::FoundOtherProcessWindow() as it is no longer required.

It was introduced in https://codereview.chromium.org/6625037 to prevent the toast from being shown when Chrome was already running; however, now that Chrome returns early if it fails to grab the singleton, this code is never reached in a state where the current process doesn't hold the singleton.


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170957

[gab, 2012-11-30 19:52:24]

Carlos, please take a look.

Thanks,
Gab

[gab, 2012-12-03 00:33:54]

ping cpu@.

Thanks,
Gab

[cpu_(ooo_6.6-7.5), 2012-12-03 19:01:56]

lgtm

please manual test by
1. build with branding=chrome
2. run chrome --try-chrome-again=0
3. observe but don't disturb the toast
4. try starting another chrome

[gab, 2012-12-03 20:36:13]

On 2012/12/03 19:01:56, cpu wrote:
> lgtm
> 
> please manual test by
> 1. build with branding=chrome
> 2. run chrome --try-chrome-again=0
> 3. observe but don't disturb the toast
> 4. try starting another chrome

Thanks, tried this and it works (i.e. Chrome rendez-vous with the toast and
doesn't create another process -- would be nice if it created a window and
dismissed the toast?)

Also tried running the toast if Chrome is already running, found
crbug.com/163987 which is also a bug on current ToT.

Also found Win8 specific bug, also on ToT: crbug.com/163985.

Will go ahead and commit this as this needs to go away as the new
ProcessSingleton will not support this (as the singleton is now grabbed in
Create() instead of the constructor and this method would not be callable before
Create() has been called -- https://codereview.chromium.org/11099053/).

Thanks,
Gab

[commit-bot: I haz the power, 2012-12-03 21:07:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gab@chromium.org/11419258/5003

[commit-bot: I haz the power, 2012-12-03 21:07:22]

Presubmit check for 11419258-5003 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome

[gab, 2012-12-03 21:12:53]

+thakis for chrome/ OWNER approval -- feel free to CQ.

Thanks,
Gab

[Nico, 2012-12-03 21:13:45]

lgtm stamp

[commit-bot: I haz the power, 2012-12-03 21:14:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gab@chromium.org/11419258/5003

[commit-bot: I haz the power, 2012-12-03 21:32:34]

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-12-04 03:57:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gab@chromium.org/11419258/5003

[commit-bot: I haz the power, 2012-12-04 07:59:51]

Retried try job too often on mac_rel for step(s) browser_tests

[commit-bot: I haz the power, 2012-12-04 14:33:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gab@chromium.org/11419258/5003

[commit-bot: I haz the power, 2012-12-04 15:24:02]

Change committed as 170957